Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h

Issue 2610513003: Avoid unnecessary updateActiveStyle comparing shadow styles. (Closed)
Patch Set: Added tests. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h
diff --git a/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h b/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h
index 2ca625c22f1b4fa36a6ab4a1ef368714d70e3caa..dad35f41afa55895ae63ac59d0ffec7533ecb5f2 100644
--- a/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h
+++ b/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h
@@ -76,6 +76,8 @@ class ScopedStyleResolver final : public GarbageCollected<ScopedStyleResolver> {
void setNeedsAppendAllSheets() { m_needsAppendAllSheets = true; }
static void keyframesRulesAdded(const TreeScope&);
static ContainerNode& invalidationRootForTreeScope(const TreeScope&);
+ CORE_EXPORT static bool hasSameStyles(const ScopedStyleResolver*,
sof 2017/01/03 18:48:34 s/has/have/, but why not an equality method rather
rune 2017/01/03 18:52:31 You mean non-static ScopedStyleResolver::hasSameSt
sof 2017/01/03 19:11:17 ok (wrt static.) Basic question -- are these autho
rune 2017/01/03 20:51:32 The stylesheets are in DOM tree order for the give
rune 2017/01/03 21:33:01 Changed has -> have.
+ const ScopedStyleResolver*);
DECLARE_TRACE();

Powered by Google App Engine
This is Rietveld 408576698