Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp

Issue 2610513003: Avoid unnecessary updateActiveStyle comparing shadow styles. (Closed)
Patch Set: Added tests. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp
index b4e489dc1471e02136c322e3a566e99535d8a68a..074ac0d18b9c79829035afcd08414b958d35a1d0 100644
--- a/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp
@@ -298,6 +298,20 @@ void ScopedStyleResolver::addTreeBoundaryCrossingRules(
RuleSubSet::create(parentStyleSheet, sheetIndex, ruleSetForScope));
}
+bool ScopedStyleResolver::hasSameStyles(const ScopedStyleResolver* first,
+ const ScopedStyleResolver* second) {
+ unsigned firstCount = first ? first->m_authorStyleSheets.size() : 0;
+ unsigned secondCount = second ? second->m_authorStyleSheets.size() : 0;
sof 2017/01/03 18:48:34 Using size_t would avoid the (unlikely) problem of
rune 2017/01/03 21:33:01 Done.
+ if (firstCount != secondCount)
+ return false;
+ while (firstCount--) {
+ if (first->m_authorStyleSheets[firstCount]->contents() !=
+ second->m_authorStyleSheets[firstCount]->contents())
+ return false;
+ }
+ return true;
+}
+
DEFINE_TRACE(ScopedStyleResolver::RuleSubSet) {
visitor->trace(m_parentStyleSheet);
visitor->trace(m_ruleSet);

Powered by Google App Engine
This is Rietveld 408576698