Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/test/base/v8_unit_test.h

Issue 2610473002: Use TaskScheduler instead of WorkerPool in v8_platform.cc. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/public/test/render_view_test.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TEST_BASE_V8_UNIT_TEST_H_ 5 #ifndef CHROME_TEST_BASE_V8_UNIT_TEST_H_
6 #define CHROME_TEST_BASE_V8_UNIT_TEST_H_ 6 #define CHROME_TEST_BASE_V8_UNIT_TEST_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/files/file_path.h" 11 #include "base/files/file_path.h"
12 #include "base/strings/string_piece.h" 12 #include "base/strings/string_piece.h"
13 #include "base/test/scoped_async_task_scheduler.h"
13 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
14 #include "v8/include/v8.h" 15 #include "v8/include/v8.h"
15 16
16 // A superclass for unit tests that involve running JavaScript. This class 17 // A superclass for unit tests that involve running JavaScript. This class
17 // sets up V8 context and has methods that make it easy to execute scripts in 18 // sets up V8 context and has methods that make it easy to execute scripts in
18 // this context as well as call functions in the context. 19 // this context as well as call functions in the context.
19 class V8UnitTest : public testing::Test { 20 class V8UnitTest : public testing::Test {
20 public: 21 public:
21 V8UnitTest(); 22 V8UnitTest();
22 ~V8UnitTest() override; 23 ~V8UnitTest() override;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 // capture and hold the results for analysis by |RunJavascriptF|. 68 // capture and hold the results for analysis by |RunJavascriptF|.
68 static void ChromeSend(const v8::FunctionCallbackInfo<v8::Value>& args); 69 static void ChromeSend(const v8::FunctionCallbackInfo<v8::Value>& args);
69 70
70 private: 71 private:
71 // Executes all added javascript libraries. Returns true if no errors. 72 // Executes all added javascript libraries. Returns true if no errors.
72 bool ExecuteJavascriptLibraries(); 73 bool ExecuteJavascriptLibraries();
73 74
74 // Initializes paths and libraries. 75 // Initializes paths and libraries.
75 void InitPathsAndLibraries(); 76 void InitPathsAndLibraries();
76 77
78 // Required by gin::V8Platform::CallOnBackgroundThread(). Can't be a
79 // ScopedTaskScheduler because v8 synchronously waits for tasks to run.
80 base::test::ScopedAsyncTaskScheduler scoped_async_task_scheduler_;
81
77 // Handle scope that is used throughout the life of this class. 82 // Handle scope that is used throughout the life of this class.
78 v8::HandleScope handle_scope_; 83 v8::HandleScope handle_scope_;
79 84
80 // Context for the JavaScript in the test. 85 // Context for the JavaScript in the test.
81 v8::Persistent<v8::Context> context_; 86 v8::Persistent<v8::Context> context_;
82 87
83 // User added libraries. 88 // User added libraries.
84 std::vector<base::FilePath> user_libraries_; 89 std::vector<base::FilePath> user_libraries_;
85 }; 90 };
86 91
87 #endif // CHROME_TEST_BASE_V8_UNIT_TEST_H_ 92 #endif // CHROME_TEST_BASE_V8_UNIT_TEST_H_
OLDNEW
« no previous file with comments | « no previous file | content/public/test/render_view_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698