Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 261042: Remove pthreads from build and installer files. (Closed)

Created:
11 years, 2 months ago by tim (not reviewing)
Modified:
9 years, 6 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews_googlegroups.com, ncarter (slow), ben+cc_chromium.org, idana, pam+watch_chromium.org, kuchhal
Visibility:
Public.

Description

Remove pthreads from build and installer files. We can yank it from deps/ following this. BUG=19895 TEST=sync_unit_tests Committed http://src.chromium.org/viewvc/chrome?view=rev&revision=28642

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1235 lines) Patch
M DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/engine/syncer_thread.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/browser/sync/engine/syncer_thread_pthreads.h View 1 chunk +0 lines, -284 lines 0 comments Download
D chrome/browser/sync/engine/syncer_thread_pthreads.cc View 1 chunk +0 lines, -582 lines 0 comments Download
D chrome/browser/sync/util/compat_pthread.h View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/sync/util/pthread_helpers.h View 1 chunk +0 lines, -133 lines 0 comments Download
D chrome/browser/sync/util/pthread_helpers.cc View 1 chunk +0 lines, -162 lines 0 comments Download
D chrome/browser/sync/util/pthread_helpers_fwd.h View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/chrome.gyp View 8 chunks +0 lines, -25 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/win/FILES View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tim (not reviewing)
The try compile failures will be fixed once I land http://codereview.chromium.org/273007
11 years, 2 months ago (2009-10-09 18:43:32 UTC) #1
ncarter (slow)
LGTM for great justice! (Conditioned as always on a successful trybot run after you land ...
11 years, 2 months ago (2009-10-09 18:51:07 UTC) #2
tim (not reviewing)
11 years, 2 months ago (2009-10-09 19:04:25 UTC) #3
On 2009/10/09 18:51:07, nick wrote:
> LGTM for great justice! (Conditioned as always on a successful trybot run
after
> you land the dependent changes.  When you submit to the trybot, please specify
> the option for a clean build; this is the sort of change that needs one.)

Thanks for the reminder.
> 
> If you wanted to, you could go ahead and remove the DEPS file entry with this
> change.

Done!
> 
> http://codereview.chromium.org/261042/diff/1/13
> File chrome/tools/build/win/FILES (right):
> 
> http://codereview.chromium.org/261042/diff/1/13#newcode63
> Line 63: wow_helper.exe
> Make sure there is a newline at the end of this file; otherwise wow_helper.exe
> won't get archived.

Powered by Google App Engine
This is Rietveld 408576698