Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

Issue 2610383002: Migrate WTF::Vector::append() to ::push_back() [part 8 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
index 3b6c2df83f94cd21beeb68eb8040167ae23f16bb..017e59aa9c34d41eb6df00cd3bf2ac31ec9c3c58 100644
--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
@@ -276,7 +276,7 @@ static Vector<String> normalizeEventTypes(
const v8::FunctionCallbackInfo<v8::Value>& info) {
Vector<String> types;
if (info.Length() > 1 && info[1]->IsString())
- types.append(toCoreString(info[1].As<v8::String>()));
+ types.push_back(toCoreString(info[1].As<v8::String>()));
if (info.Length() > 1 && info[1]->IsArray()) {
v8::Local<v8::Array> typesArray = v8::Local<v8::Array>::Cast(info[1]);
for (size_t i = 0; i < typesArray->Length(); ++i) {
@@ -285,7 +285,7 @@ static Vector<String> normalizeEventTypes(
.ToLocal(&typeValue) ||
!typeValue->IsString())
continue;
- types.append(toCoreString(v8::Local<v8::String>::Cast(typeValue)));
+ types.push_back(toCoreString(v8::Local<v8::String>::Cast(typeValue)));
}
}
if (info.Length() == 1)
@@ -321,7 +321,7 @@ static Vector<String> normalizeEventTypes(
Vector<String>({"resize", "scroll", "zoom", "focus", "blur", "select",
"input", "change", "submit", "reset"}));
else
- outputTypes.append(types[i]);
+ outputTypes.push_back(types[i]);
}
return outputTypes;
}
@@ -456,13 +456,13 @@ void ThreadDebugger::startRepeatingTimer(
double interval,
V8InspectorClient::TimerCallback callback,
void* data) {
- m_timerData.append(data);
- m_timerCallbacks.append(callback);
+ m_timerData.push_back(data);
+ m_timerCallbacks.push_back(callback);
std::unique_ptr<Timer<ThreadDebugger>> timer = WTF::wrapUnique(
new Timer<ThreadDebugger>(this, &ThreadDebugger::onTimer));
Timer<ThreadDebugger>* timerPtr = timer.get();
- m_timers.append(std::move(timer));
+ m_timers.push_back(std::move(timer));
timerPtr->startRepeating(interval, BLINK_FROM_HERE);
}
« no previous file with comments | « third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698