Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp

Issue 2610383002: Migrate WTF::Vector::append() to ::push_back() [part 8 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp b/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
index 75bd07269d8660866023f529f5f32799637ae407..7a4e20ac3abacad73ebb8812bb28c69c5d2e5ce5 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
@@ -101,7 +101,7 @@ void InspectorResourceContentLoader::start() {
HeapVector<Member<Document>> documents;
InspectedFrames* inspectedFrames = InspectedFrames::create(m_inspectedFrame);
for (LocalFrame* frame : *inspectedFrames) {
- documents.append(frame->document());
+ documents.push_back(frame->document());
documents.appendVector(InspectorPageAgent::importsForFrame(frame));
}
for (Document* document : documents) {
@@ -125,7 +125,7 @@ void InspectorResourceContentLoader::start() {
Resource* resource = RawResource::fetch(request, document->fetcher());
if (resource) {
// Prevent garbage collection by holding a reference to this resource.
- m_resources.append(resource);
+ m_resources.push_back(resource);
ResourceClient* resourceClient = new ResourceClient(this);
m_pendingResourceClients.add(resourceClient);
resourceClient->waitForResource(resource);
@@ -150,7 +150,7 @@ void InspectorResourceContentLoader::start() {
if (!resource)
continue;
// Prevent garbage collection by holding a reference to this resource.
- m_resources.append(resource);
+ m_resources.push_back(resource);
ResourceClient* resourceClient = new ResourceClient(this);
m_pendingResourceClients.add(resourceClient);
resourceClient->waitForResource(resource);
@@ -171,7 +171,7 @@ void InspectorResourceContentLoader::ensureResourcesContentLoaded(
if (!m_started)
start();
m_callbacks.add(clientId, Callbacks())
- .storedValue->value.append(std::move(callback));
+ .storedValue->value.push_back(std::move(callback));
checkDone();
}

Powered by Google App Engine
This is Rietveld 408576698