Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

Issue 2610383002: Migrate WTF::Vector::append() to ::push_back() [part 8 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
index 1f5c8b81f562bb4ca7fc51a1e4dc89e4cc48c74d..5412baed6b920b849264a4b8eff25754b339e212 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
@@ -172,7 +172,7 @@ void InspectorRevalidateDOMTask::onTimer(TimerBase*) {
// be called after m_domAgent has been destroyed.
HeapVector<Member<Element>> elements;
for (auto& attribute : m_styleAttrInvalidatedElements)
- elements.append(attribute.get());
+ elements.push_back(attribute.get());
m_domAgent->styleAttributeInvalidated(elements);
m_styleAttrInvalidatedElements.clear();
}
@@ -271,7 +271,7 @@ HeapVector<Member<Document>> InspectorDOMAgent::documents() {
if (m_document) {
for (LocalFrame* frame : *m_inspectedFrames) {
if (Document* document = frame->document())
- result.append(document);
+ result.push_back(document);
}
}
return result;
@@ -661,7 +661,7 @@ int InspectorDOMAgent::pushNodePathToFrontend(Node* nodeToPush,
Node* parent = innerParentNode(node);
if (!parent)
return 0;
- path.append(parent);
+ path.push_back(parent);
if (nodeMap->get(parent))
break;
node = parent;
@@ -690,7 +690,7 @@ int InspectorDOMAgent::pushNodePathToFrontend(Node* nodeToPush) {
// Node being pushed is detached -> push subtree root.
NodeToIdMap* newMap = new NodeToIdMap;
NodeToIdMap* danglingMap = newMap;
- m_danglingNodeToIdMaps.append(newMap);
+ m_danglingNodeToIdMaps.push_back(newMap);
std::unique_ptr<protocol::Array<protocol::DOM::Node>> children =
protocol::Array<protocol::DOM::Node>::create();
children->addItem(buildObjectForNode(node, 0, false, danglingMap));
@@ -1072,7 +1072,7 @@ Response InspectorDOMAgent::performSearch(
.storedValue->value;
for (auto& result : resultCollector)
- resultsIt->append(result);
+ resultsIt->push_back(result);
*resultCount = resultsIt->size();
return Response::OK();
@@ -1439,7 +1439,7 @@ Response InspectorDOMAgent::setFileInputFiles(
Vector<String> paths;
for (size_t index = 0; index < files->length(); ++index)
- paths.append(files->get(index));
+ paths.push_back(files->get(index));
toHTMLInputElement(node)->setFilesFromPaths(paths);
return Response::OK();
}

Powered by Google App Engine
This is Rietveld 408576698