Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2354)

Unified Diff: chrome/browser/chromeos/login/ui/preloaded_web_view_factory.cc

Issue 2610373002: cros: Only preload the lock screen; do not reuse it. (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/ui/preloaded_web_view_factory.cc
diff --git a/chrome/browser/chromeos/login/ui/shared_web_view_factory.cc b/chrome/browser/chromeos/login/ui/preloaded_web_view_factory.cc
similarity index 52%
rename from chrome/browser/chromeos/login/ui/shared_web_view_factory.cc
rename to chrome/browser/chromeos/login/ui/preloaded_web_view_factory.cc
index a42a30b3f4972c20c0c27f223fcd0c095aa2b785..923a49d96806827440197090e94b9f213aebd167 100644
--- a/chrome/browser/chromeos/login/ui/shared_web_view_factory.cc
+++ b/chrome/browser/chromeos/login/ui/preloaded_web_view_factory.cc
@@ -2,9 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/chromeos/login/ui/shared_web_view_factory.h"
+#include "chrome/browser/chromeos/login/ui/preloaded_web_view_factory.h"
-#include "chrome/browser/chromeos/login/ui/shared_web_view.h"
+#include "chrome/browser/chromeos/login/ui/preloaded_web_view.h"
#include "chrome/browser/chromeos/profiles/profile_helper.h"
#include "chrome/browser/profiles/incognito_helpers.h"
#include "chrome/browser/profiles/profile.h"
@@ -13,36 +13,36 @@
namespace chromeos {
// static
-SharedWebView* SharedWebViewFactory::GetForProfile(Profile* profile) {
- auto result = static_cast<SharedWebView*>(
+PreloadedWebView* PreloadedWebViewFactory::GetForProfile(Profile* profile) {
+ auto result = static_cast<PreloadedWebView*>(
GetInstance()->GetServiceForBrowserContext(profile, true));
return result;
}
// static
-SharedWebViewFactory* SharedWebViewFactory::GetInstance() {
- return base::Singleton<SharedWebViewFactory>::get();
+PreloadedWebViewFactory* PreloadedWebViewFactory::GetInstance() {
+ return base::Singleton<PreloadedWebViewFactory>::get();
}
-SharedWebViewFactory::SharedWebViewFactory()
+PreloadedWebViewFactory::PreloadedWebViewFactory()
: BrowserContextKeyedServiceFactory(
- "SharedWebViewFactory",
+ "PreloadedWebViewFactory",
BrowserContextDependencyManager::GetInstance()) {}
-SharedWebViewFactory::~SharedWebViewFactory() {}
+PreloadedWebViewFactory::~PreloadedWebViewFactory() {}
-content::BrowserContext* SharedWebViewFactory::GetBrowserContextToUse(
+content::BrowserContext* PreloadedWebViewFactory::GetBrowserContextToUse(
content::BrowserContext* context) const {
- // Make sure that only the SigninProfile is using a shared webview.
+ // Make sure that only the SigninProfile is using a preloaded webview.
if (Profile::FromBrowserContext(context) != ProfileHelper::GetSigninProfile())
return nullptr;
return context;
}
-KeyedService* SharedWebViewFactory::BuildServiceInstanceFor(
+KeyedService* PreloadedWebViewFactory::BuildServiceInstanceFor(
content::BrowserContext* context) const {
- return new SharedWebView(Profile::FromBrowserContext(context));
+ return new PreloadedWebView(Profile::FromBrowserContext(context));
}
} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/login/ui/preloaded_web_view_factory.h ('k') | chrome/browser/chromeos/login/ui/shared_web_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698