cros: Only preload the lock screen; do not reuse it.

chrome/browser/chromeos/login/lock/webui_screen_locker.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/lock/webui_screen_locker.h"
 
 #include "ash/common/wm_shell.h"
 #include "ash/shell.h"
 #include "ash/system/chromeos/power/power_event_observer.h"
 #include "base/command_line.h"
 #include "base/feature_list.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/chromeos/accessibility/accessibility_util.h"
 #include "chrome/browser/chromeos/login/helper.h"
 #include "chrome/browser/chromeos/login/lock/screen_locker.h"
-#include "chrome/browser/chromeos/login/ui/shared_web_view.h"
-#include "chrome/browser/chromeos/login/ui/shared_web_view_factory.h"
-#include "chrome/browser/chromeos/login/ui/web_view_handle.h"
+#include "chrome/browser/chromeos/login/ui/preloaded_web_view.h"
+#include "chrome/browser/chromeos/login/ui/preloaded_web_view_factory.h"
 #include "chrome/browser/chromeos/login/ui/webui_login_display.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
 #include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "components/prefs/pref_service.h"
@@ skipping 24 matching lines @@
 void DisableKeyboardOverscroll() {
   keyboard::SetKeyboardOverscrollOverride(
       keyboard::KEYBOARD_OVERSCROLL_OVERRIDE_DISABLED);
 }
 
 void ResetKeyboardOverscrollOverride() {
   keyboard::SetKeyboardOverscrollOverride(
       keyboard::KEYBOARD_OVERSCROLL_OVERRIDE_NONE);
 }
 
-chromeos::WebUILoginView::WebViewSettings BuildSettings() {
-  chromeos::WebUILoginView::WebViewSettings settings;
-  if (chromeos::WebUIScreenLocker::ShouldShareLockScreen()) {
-    settings.preloaded_url = GURL(kLoginURL);
-    settings.web_view_title =
-        l10n_util::GetStringUTF16(IDS_LOCK_SCREEN_TASK_MANAGER_NAME);
-  }
-  return settings;
-}
-
 }  // namespace
 
 namespace chromeos {
 
 // static
-bool WebUIScreenLocker::ShouldShareLockScreen() {
+void WebUIScreenLocker::RequestPreload() {
+  if (!ShouldPreloadLockScreen())
+    return;
+
+  VLOG(1) << "Preloading lock screen";
+  PreloadedWebView* preloaded_web_view =
+      PreloadedWebViewFactory::GetForProfile(ProfileHelper::GetSigninProfile());
+  preloaded_web_view->PreloadOnIdle(
+      base::BindOnce(&WebUIScreenLocker::DoPreload));
+}
+
+// static
+bool WebUIScreenLocker::ShouldPreloadLockScreen() {
   Profile* profile = ProfileHelper::Get()->GetProfileByUser(
       user_manager::UserManager::Get()->GetActiveUser());
 
-  // We only want to share the lock screen if the user is likely to see the lock
-  // screen (since caching the lock screen uses memory). Without preloading,
-  // showing the lock screen can take so long we will timeout and crash the
-  // browser process (which currently takes down all of Chrome). See
+  // We only want to preload the lock screen if the user is likely to see the
+  // lock screen (since caching the lock screen uses memory). Without
+  // preloading, showing the lock screen can take so long we will timeout and
+  // crash the browser process (which currently takes down all of Chrome). See
   // crbug.com/452599 for more context.
   //
   // prefs::kEnableAutoScreenLock controls if the lock screen is shown on
   // suspend, so that is our primary hueristic.
 
   // Note that |profile| can be null in tests.
-  return base::FeatureList::IsEnabled(features::kSharedLockScreen) && profile &&
+  return base::FeatureList::IsEnabled(features::kPreloadLockScreen) &&
+         profile &&
          profile->GetPrefs()->GetBoolean(prefs::kEnableAutoScreenLock);
 }
 
 // static
-void WebUIScreenLocker::Preload() {
-  DCHECK(ShouldShareLockScreen());
-  VLOG(1) << "Preloading lock screen";
-
-  SharedWebView* shared_web_view =
-      SharedWebViewFactory::GetForProfile(ProfileHelper::GetSigninProfile());
-
-  scoped_refptr<WebViewHandle> web_view_handle;
-  if (!shared_web_view->has_web_view() &&
-      !shared_web_view->Get(GURL(kLoginURL), &web_view_handle)) {
-    web_view_handle->web_view()->LoadInitialURL(GURL(kLoginURL));
-    InitializeWebView(
-        web_view_handle->web_view(),
-        l10n_util::GetStringUTF16(IDS_LOCK_SCREEN_TASK_MANAGER_NAME));
-  }
+std::unique_ptr<views::WebView> WebUIScreenLocker::DoPreload(Profile* profile) {
+  auto web_view = base::MakeUnique<views::WebView>(profile);
+  web_view->set_owned_by_client();
+  web_view->LoadInitialURL(GURL(kLoginURL));
+  InitializeWebView(web_view.get(), l10n_util::GetStringUTF16(
+                                        IDS_LOCK_SCREEN_TASK_MANAGER_NAME));
+  return web_view;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // WebUIScreenLocker implementation.
 
 WebUIScreenLocker::WebUIScreenLocker(ScreenLocker* screen_locker)
-    : WebUILoginView(BuildSettings()),
+    : WebUILoginView(BuildConfigSettings()),
       screen_locker_(screen_locker),
       network_state_helper_(new login::NetworkStateHelper),
       weak_factory_(this) {
   set_should_emit_login_prompt_visible(false);
   ash::WmShell::Get()->AddLockStateObserver(this);
   ash::WmShell::Get()->AddShellObserver(this);
   display::Screen::GetScreen()->AddObserver(this);
   DBusThreadManager::Get()->GetPowerManagerClient()->AddObserver(this);
 
   if (keyboard::KeyboardController::GetInstance()) {
@@ skipping 16 matching lines @@
   // delegate set in ShowSigninScreen so that it no longer points to us.
   if (login_display_.get() && GetOobeUI())
     GetOobeUI()->ResetSigninScreenHandlerDelegate();
 
   if (keyboard::KeyboardController::GetInstance() && is_observing_keyboard_) {
     keyboard::KeyboardController::GetInstance()->RemoveObserver(this);
     is_observing_keyboard_ = false;
   }
 
   ResetKeyboardOverscrollOverride();
+
+  RequestPreload();
 }
 
 void WebUIScreenLocker::LockScreen() {
   gfx::Rect bounds = display::Screen::GetScreen()->GetPrimaryDisplay().bounds();
 
   lock_time_ = base::TimeTicks::Now();
   lock_window_ = new LockWindow(this);
   lock_window_->AddObserver(this);
 
   Init();
@@ skipping 66 matching lines @@
       "cr.ui.Oobe.forceLockedUserPodFocus");
 }
 
 void WebUIScreenLocker::ResetAndFocusUserPod() {
   if (!webui_ready_)
     return;
   GetWebUI()->CallJavascriptFunctionUnsafe("cr.ui.Oobe.clearUserPodPassword");
   FocusUserPod();
 }
 
+WebUILoginView::WebViewSettings WebUIScreenLocker::BuildConfigSettings() {
+  chromeos::WebUILoginView::WebViewSettings settings;
+  if (chromeos::WebUIScreenLocker::ShouldPreloadLockScreen()) {
+    settings.check_for_preload = true;
+    settings.web_view_title =
+        l10n_util::GetStringUTF16(IDS_LOCK_SCREEN_TASK_MANAGER_NAME);
+  }
+  return settings;
+}
+
 void WebUIScreenLocker::OnLockWebUIReady() {
   VLOG(1) << "WebUI ready; lock window is "
           << (lock_ready_ ? "too" : "not");
   webui_ready_ = true;
   if (lock_ready_)
     ScreenLockReady();
 }
 
 void WebUIScreenLocker::OnLockBackgroundDisplayed() {
   UMA_HISTOGRAM_TIMES("LockScreen.BackgroundReady",
@@ skipping 196 matching lines @@
   }
 
   if (GetOobeUI()) {
     const gfx::Size& size = primary_display.size();
     GetOobeUI()->GetCoreOobeActor()->SetClientAreaSize(size.width(),
                                                        size.height());
   }
 }
 
 }  // namespace chromeos