Issue 261033: GTK: Draw a strikethrough over bad https....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 261033: GTK: Draw a strikethrough over bad https.... (Closed)

Created:
11 years, 2 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Daniel Erat, Evan Martin

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK: Draw a strikethrough over bad https. TEST=https://metafilter.com BUG=23339 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28510

Patch Set 2 : styles #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -6 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_gtk.h	View	1	3 chunks	+18 lines, -0 lines	0 comments	Download
	M	chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc	View	1	4 chunks	+67 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

LGTM http://codereview.chromium.org/261033/diff/1/2 File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right): http://codereview.chromium.org/261033/diff/1/2#newcode1085 Line 1085: strikethrough_rect.Inset(kStrikethroughStrokeWidth, kStrikethroughStrokeWidth); wrap long line

11 years, 2 months ago (2009-10-08 23:47:43 UTC) #2

Evan Martin

11 years, 2 months ago (2009-10-08 23:48:39 UTC) #3

Wow, awesome!  You are the man!

LGTM

http://codereview.chromium.org/261033/diff/1/2
File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right):

http://codereview.chromium.org/261033/diff/1/2#newcode1085
Line 1085: strikethrough_rect.Inset(kStrikethroughStrokeWidth,
kStrikethroughStrokeWidth);
80

http://codereview.chromium.org/261033/diff/1/3
File chrome/browser/autocomplete/autocomplete_edit_view_gtk.h (right):

http://codereview.chromium.org/261033/diff/1/3#newcode429
Line 429: CharRange strikethrough_;
Comment on this?

Expand Messages | Collapse Messages

Issue 261033: GTK: Draw a strikethrough over bad https.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : styles #

Messages