Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: runtime/vm/thread.cc

Issue 2610253002: Added isolate + thread high watermark tracking to Observatory (Closed)
Patch Set: Converted uint values to uintptr_t Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/thread.h ('k') | runtime/vm/thread_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread.cc
diff --git a/runtime/vm/thread.cc b/runtime/vm/thread.cc
index 1b3428eaa62eba6a88e01859b9b294528db1cce3..27c7144912d1ad23948c82ecbbb3f0519876a1d6 100644
--- a/runtime/vm/thread.cc
+++ b/runtime/vm/thread.cc
@@ -38,6 +38,8 @@ Thread::~Thread() {
delete compiler_stats_;
compiler_stats_ = NULL;
}
+ // All zone allocated memory should be free by this point.
+ ASSERT(current_thread_memory_ == 0);
// There should be no top api scopes at this point.
ASSERT(api_top_scope() == NULL);
// Delete the resusable api scope if there is one.
@@ -74,6 +76,8 @@ Thread::Thread(Isolate* isolate)
os_thread_(NULL),
thread_lock_(new Monitor()),
zone_(NULL),
+ current_thread_memory_(0),
+ memory_high_watermark_(0),
api_reusable_scope_(NULL),
api_top_scope_(NULL),
top_resource_(NULL),
@@ -213,6 +217,7 @@ void Thread::PrintJSON(JSONStream* stream) const {
jsobj.AddPropertyF("id", "threads/%" Pd "",
OSThread::ThreadIdToIntPtr(os_thread()->trace_id()));
jsobj.AddProperty("kind", TaskKindToCString(task_kind()));
+ jsobj.AddPropertyF("_memoryHighWatermark", "%" Pu "", memory_high_watermark_);
Zone* zone = zone_;
{
JSONArray zone_info_array(&jsobj, "zones");
« no previous file with comments | « runtime/vm/thread.h ('k') | runtime/vm/thread_registry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698