Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: runtime/vm/isolate.cc

Issue 2610253002: Added isolate + thread high watermark tracking to Observatory (Closed)
Patch Set: Converted uint values to uintptr_t Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 8304532470999c81ea515843ad6496c8348db0f3..d697cd8e0a2b0a8e1522df94d4f2d52624b45ec4 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -776,6 +776,7 @@ Isolate::Isolate(const Dart_IsolateFlags& api_flags)
single_step_(false),
thread_registry_(new ThreadRegistry()),
safepoint_handler_(new SafepointHandler(this)),
+ memory_high_watermark_(0),
message_notify_callback_(NULL),
name_(NULL),
debugger_name_(NULL),
@@ -2103,7 +2104,8 @@ void Isolate::PrintJSON(JSONStream* stream, bool ref) {
}
}
- jsobj.AddProperty("threads", thread_registry_);
+ jsobj.AddPropertyF("_memoryHighWatermark", "%" Pu "", memory_high_watermark_);
+ jsobj.AddProperty("_threads", thread_registry_);
}
#endif
@@ -2653,6 +2655,8 @@ Thread* Isolate::ScheduleThread(bool is_mutator, bool bypass_safepoint) {
thread = thread_registry()->GetFreeThreadLocked(this, is_mutator);
ASSERT(thread != NULL);
+ thread->ResetHighWatermark();
+
// Set up other values and set the TLS value.
thread->isolate_ = this;
ASSERT(heap() != NULL);
@@ -2699,6 +2703,7 @@ void Isolate::UnscheduleThread(Thread* thread,
// Ensure that the thread reports itself as being at a safepoint.
thread->EnterSafepoint();
}
+ UpdateMemoryHighWatermark();
OSThread* os_thread = thread->os_thread();
ASSERT(os_thread != NULL);
os_thread->DisableThreadInterrupts();
@@ -2719,6 +2724,15 @@ void Isolate::UnscheduleThread(Thread* thread,
}
+void Isolate::UpdateMemoryHighWatermark() {
+ const uintptr_t thread_watermarks_total =
+ thread_registry()->ThreadHighWatermarksTotalLocked();
+ if (thread_watermarks_total > memory_high_watermark_) {
+ memory_high_watermark_ = thread_watermarks_total;
+ }
+}
+
+
static RawInstance* DeserializeObject(Thread* thread,
uint8_t* obj_data,
intptr_t obj_len) {
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698