Added isolate + thread high watermark tracking to Observatory

Added isolate + thread high watermark tracking to Observatory

This is a fixed version of c84f30741c90d040254767ff769a40d2cba3fb1a that
resolves issues with comparing uint and intptr_t.

Original Commit Message:
Added tracking of memory usage inside of threads. In addition, the max memory usage is kept track of using a high watermark for both the threads and the isolates. Isolate high watermark information is updated when a thread exits the isolate. The isolate high watermark consists of the sum of all thread high watermarks (including the high watermark of the exiting thread). High watermark information for both threads and isolates is now visible in the isolate view in the Observatory.

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/4024151adbf9699ff93d6953f3cd63a5ab4341c7

[bkonyi, 2017-01-04 23:49:51]

bkonyi@google.com changed reviewers:
+ johnmccutchan@google.com, zra@google.com

[bkonyi, 2017-01-04 23:49:52]

https://codereview.chromium.org/2610253002/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2610253002/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:2728: const uint thread_watermarks_total =
This is the line that was causing the failure. Changed from intptr_t to uint.

[zra, 2017-01-04 23:53:26]

https://codereview.chromium.org/2610253002/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2610253002/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:2728: const uint thread_watermarks_total =
On 2017/01/04 23:49:52, bkonyi wrote:
> This is the line that was causing the failure. Changed from intptr_t to uint.

Should this be uintptr_t?

[bkonyi, 2017-01-05 00:09:02]

https://codereview.chromium.org/2610253002/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2610253002/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:2728: const uint thread_watermarks_total =
On 2017/01/04 at 23:53:26, zra wrote:
> On 2017/01/04 23:49:52, bkonyi wrote:
> > This is the line that was causing the failure. Changed from intptr_t to
uint.
> 
> Should this be uintptr_t?

I'm not certain myself. John had said I should be using uint in this case
instead of intptr_t during the last review. However, I apparently missed
updating this particular instance.

[bkonyi, 2017-01-05 14:36:28]

https://codereview.chromium.org/2610253002/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2610253002/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:2728: const uint thread_watermarks_total =
On 2017/01/04 at 23:53:26, zra wrote:
> On 2017/01/04 23:49:52, bkonyi wrote:
> > This is the line that was causing the failure. Changed from intptr_t to
uint.
> 
> Should this be uintptr_t?

Done.

[Cutch, 2017-01-05 14:47:51]

lgtm

[bkonyi, 2017-01-05 22:25:37]

Description was changed from

==========
Added isolate + thread high watermark tracking to Observatory

This is a fixed version of c84f30741c90d040254767ff769a40d2cba3fb1a that
resolves issues with comparing uint and intptr_t.

Original Commit Message:
Added tracking of memory usage inside of threads. In addition, the max memory
usage is kept track of using a high watermark for both the threads and the
isolates. Isolate high watermark information is updated when a thread exits the
isolate. The isolate high watermark consists of the sum of all thread high
watermarks (including the high watermark of the exiting thread). High watermark
information for both threads and isolates is now visible in the isolate view in
the Observatory.

BUG=
==========

to

==========
Added isolate + thread high watermark tracking to Observatory

This is a fixed version of c84f30741c90d040254767ff769a40d2cba3fb1a that
resolves issues with comparing uint and intptr_t.

Original Commit Message:
Added tracking of memory usage inside of threads. In addition, the max memory
usage is kept track of using a high watermark for both the threads and the
isolates. Isolate high watermark information is updated when a thread exits the
isolate. The isolate high watermark consists of the sum of all thread high
watermarks (including the high watermark of the exiting thread). High watermark
information for both threads and isolates is now visible in the isolate view in
the Observatory.

BUG=
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4024151adbf9699ff93d6953f3cd63a5ab4341c7
==========

[bkonyi, 2017-01-05 22:25:38]

Committed patchset #2 (id:20001) manually as
4024151adbf9699ff93d6953f3cd63a5ab4341c7 (presubmit successful).