Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/oninstall-script-error.https.html

Issue 2610243002: Import wpt@5e1a3b80cea8d36774d2afd78b29a74792e9f15a (Closed)
Patch Set: Rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/oninstall-script-error.https.html
diff --git a/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/oninstall-script-error.https.html b/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/oninstall-script-error.https.html
index a9ca19cab7fd4d371b776b00f34562472993e02e..fe7f6e901206e07b611496a191a8023516aa4b84 100644
--- a/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/oninstall-script-error.https.html
+++ b/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/oninstall-script-error.https.html
@@ -33,18 +33,23 @@ function make_test(name, script, expect_install) {
{
name: 'install handler throws an error',
script: 'resources/oninstall-throw-error-worker.js',
- expect_install: false
+ expect_install: true
},
{
name: 'install handler throws an error, error handler does not cancel',
script: 'resources/oninstall-throw-error-with-empty-onerror-worker.js',
- expect_install: false
+ expect_install: true
},
{
name: 'install handler dispatches an event that throws an error',
script: 'resources/oninstall-throw-error-from-nested-event-worker.js',
expect_install: true
},
+ {
+ name: 'install handler throws an error in the waitUntil',
+ script: 'resources/oninstall-waituntil-throw-error-worker.js',
+ expect_install: false
+ },
// The following two cases test what happens when the ServiceWorkerGlobalScope
// 'error' event handler cancels the resulting error event. Since the
@@ -54,12 +59,12 @@ function make_test(name, script, expect_install) {
{
name: 'install handler throws an error that is cancelled',
script: 'resources/oninstall-throw-error-then-cancel-worker.js',
- expect_install: false
+ expect_install: true
},
{
name: 'install handler throws an error and prevents default',
script: 'resources/oninstall-throw-error-then-prevent-default-worker.js',
- expect_install: false
+ expect_install: true
}
].forEach(function(test_case) {
make_test(test_case.name, test_case.script, test_case.expect_install);

Powered by Google App Engine
This is Rietveld 408576698