Import wpt@5e1a3b80cea8d36774d2afd78b29a74792e9f15a

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

 # Copyright (C) 2010 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 782 matching lines @@
         tests = []
         for file_path in files:
             # Path separators are normalized by relative_test_filename().
             match = re.search(r'imported/wpt/(.*)$', file_path)
             if not match:
                 tests.append(file_path)
                 continue
             path_in_wpt = match.group(1)
             manifest_items = self._manifest_items_for_path(path_in_wpt)
             assert manifest_items is not None
-            if len(manifest_items) != 1 or manifest_items[0]['url'][1:] != path_in_wpt:
+            # For most testharness tests, manifest_items looks like:
+            # [["/some/test/path.html", {}]]
+            if len(manifest_items) != 1 or manifest_items[0][0][1:] != path_in_wpt:
                 # TODO(tkent): foo.any.js and bar.worker.js should be accessed
                 # as foo.any.html, foo.any.worker, and bar.worker with WPTServe.
                 continue
             tests.append(file_path)
         return tests
 
     @memoized
     def _wpt_manifest(self):
         path = self._filesystem.join(self.layout_tests_dir(), 'imported', 'wpt', 'MANIFEST.json')
         return json.loads(self._filesystem.read_text_file(path))
 
     def _manifest_items_for_path(self, path_in_wpt):
-        """Returns a list of a dict representing ManifestItem for the specified
-        path, or None if MANIFEST.json has no items for the specified path.
+        """Returns a manifest item for the given WPT path, or None if not found.
 
-        A ManifestItem has 'path', 'url', and optional 'timeout' fields. Also,
-        it has "references" list for reference tests. It's defined in
-        web-platform-tests/tools/manifest/item.py.
+        The format of a manifest item depends on
+        https://github.com/w3c/wpt-tools/blob/master/manifest/item.py
+        and is assumed to be a list of the format [url, extras],
+        or [url, references, extras] for reftests, or None if not found.
         """
-        # Because we generate MANIFEST.json before finishing import, all
-        # entries are in 'local_changes'.
-        items = self._wpt_manifest()['local_changes']['items']
+        items = self._wpt_manifest()['items']

[qyearsley, 2017/01/05 18:48:32]

Note, if preferable, these changes (to base.py and unit test) could be extracted
to a separate CL, although they need to be done before the next import.

         if path_in_wpt in items['manual']:
             return items['manual'][path_in_wpt]
         elif path_in_wpt in items['reftest']:
             return items['reftest'][path_in_wpt]
         elif path_in_wpt in items['testharness']:
             return items['testharness'][path_in_wpt]
         return None
 
     ALL_TEST_TYPES = ['audio', 'harness', 'pixel', 'ref', 'text', 'unknown']
 
@@ skipping 958 matching lines @@
 
     def __init__(self, base, args, reference_args=None):
         self.name = base
         self.base = base
         self.args = args
         self.reference_args = args if reference_args is None else reference_args
         self.tests = set()
 
     def __repr__(self):
         return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args)