Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: services/service_manager/tests/util.cc

Issue 2610173003: Add RegisterService, split out of Connect(). (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/tests/util.cc
diff --git a/services/service_manager/tests/util.cc b/services/service_manager/tests/util.cc
index 1cc10889412134099d75bc70b1c8935dcabd345b..9b77108ed4079aa432824b1b89e113d687cacaf4 100644
--- a/services/service_manager/tests/util.cc
+++ b/services/service_manager/tests/util.cc
@@ -36,7 +36,7 @@ void QuitLoop(base::RunLoop* loop) {
std::unique_ptr<Connection> LaunchAndConnectToProcess(
const std::string& target_exe_name,
- const Identity target,
+ const Identity& target,
service_manager::Connector* connector,
base::Process* process) {
base::FilePath target_path;
@@ -74,11 +74,9 @@ std::unique_ptr<Connection> LaunchAndConnectToProcess(
std::move(pipe), 0u));
service_manager::mojom::PIDReceiverPtr receiver;
- service_manager::Connector::ConnectParams params(target);
- params.set_client_process_connection(std::move(client),
- MakeRequest(&receiver));
+ connector->RegisterService(target, std::move(client), MakeRequest(&receiver));
std::unique_ptr<service_manager::Connection> connection =
- connector->Connect(&params);
+ connector->Connect(target);
{
base::RunLoop loop;
connection->AddConnectionCompletedClosure(base::Bind(&QuitLoop, &loop));

Powered by Google App Engine
This is Rietveld 408576698