Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2610163005: Gardening: mark language/regress_28255_test SkipByDesign in configurations without mirrors. (Closed)

Created:
3 years, 11 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 11 months ago
Reviewers:
zra, kustermann
CC:
reviews_dartlang.org, zra, Johnni Winther
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gardening: mark language/regress_28255_test SkipByDesign in configurations without mirrors. R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8360a89fce5d77bc9b1bde3662b88125675e6a2a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tests/language/language.status View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
Vyacheslav Egorov (Google)
3 years, 11 months ago (2017-01-05 16:10:11 UTC) #1
Vyacheslav Egorov (Google)
3 years, 11 months ago (2017-01-05 16:11:07 UTC) #2
kustermann
lgtm
3 years, 11 months ago (2017-01-05 16:11:54 UTC) #3
Vyacheslav Egorov (Google)
Committed patchset #1 (id:1) manually as 8360a89fce5d77bc9b1bde3662b88125675e6a2a (presubmit successful).
3 years, 11 months ago (2017-01-05 16:12:09 UTC) #5
zra
https://codereview.chromium.org/2610163005/diff/1/tests/language/language.status File tests/language/language.status (right): https://codereview.chromium.org/2610163005/diff/1/tests/language/language.status#newcode208 tests/language/language.status:208: regress_28255_test: SkipByDesign It looks like the kernel status file ...
3 years, 11 months ago (2017-01-05 18:36:10 UTC) #7
zra
3 years, 11 months ago (2017-01-05 20:29:55 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/2610163005/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/2610163005/diff/1/tests/language/language.sta...
tests/language/language.status:208: regress_28255_test: SkipByDesign
On 2017/01/05 18:36:10, zra wrote:
> It looks like the kernel status file also needs an update, but I don't know
> where to add an entry to it for this test.

https://github.com/dart-lang/sdk/commit/cf1a432ac71dfd6c7e1ebf516a27bdeaea74ff95

Powered by Google App Engine
This is Rietveld 408576698