Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Unified Diff: chrome/browser/android/recently_closed_tabs_bridge.cc

Issue 2610143002: Add RecentTabsPageTest (Closed)
Patch Set: fix bad merge Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/recently_closed_tabs_bridge.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/recently_closed_tabs_bridge.cc
diff --git a/chrome/browser/android/recently_closed_tabs_bridge.cc b/chrome/browser/android/recently_closed_tabs_bridge.cc
index 5812266c8556a48347aae7067c0ce17b0402a1af..b80c3b4ef5f0f7d0964d6a1fd8e4bd9430e52207 100644
--- a/chrome/browser/android/recently_closed_tabs_bridge.cc
+++ b/chrome/browser/android/recently_closed_tabs_bridge.cc
@@ -20,7 +20,7 @@ using base::android::AttachCurrentThread;
using base::android::ConvertUTF16ToJavaString;
using base::android::ConvertUTF8ToJavaString;
using base::android::JavaParamRef;
-using base::android::ScopedJavaLocalRef;
+using base::android::ScopedJavaGlobalRef;
namespace {
@@ -53,10 +53,12 @@ void AddTabsToList(JNIEnv* env,
} // namespace
-RecentlyClosedTabsBridge::RecentlyClosedTabsBridge(Profile* profile)
- : profile_(profile),
- tab_restore_service_(NULL) {
-}
+RecentlyClosedTabsBridge::RecentlyClosedTabsBridge(
+ ScopedJavaGlobalRef<jobject> jbridge,
+ Profile* profile)
+ : bridge_(std::move(jbridge)),
+ profile_(profile),
+ tab_restore_service_(nullptr) {}
RecentlyClosedTabsBridge::~RecentlyClosedTabsBridge() {
if (tab_restore_service_)
@@ -68,13 +70,6 @@ void RecentlyClosedTabsBridge::Destroy(JNIEnv* env,
delete this;
}
-void RecentlyClosedTabsBridge::SetRecentlyClosedCallback(
- JNIEnv* env,
- const JavaParamRef<jobject>& obj,
- const JavaParamRef<jobject>& jcallback) {
- callback_.Reset(env, jcallback);
-}
-
jboolean RecentlyClosedTabsBridge::GetRecentlyClosedTabs(
JNIEnv* env,
const JavaParamRef<jobject>& obj,
@@ -152,10 +147,7 @@ void RecentlyClosedTabsBridge::ClearRecentlyClosedTabs(
void RecentlyClosedTabsBridge::TabRestoreServiceChanged(
sessions::TabRestoreService* service) {
- if (callback_.is_null())
- return;
- JNIEnv* env = AttachCurrentThread();
- Java_RecentlyClosedCallback_onUpdated(env, callback_);
+ Java_RecentlyClosedBridge_onUpdated(AttachCurrentThread(), bridge_);
}
void RecentlyClosedTabsBridge::TabRestoreServiceDestroyed(
@@ -180,9 +172,10 @@ void RecentlyClosedTabsBridge::EnsureTabRestoreService() {
}
static jlong Init(JNIEnv* env,
- const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jobject>& jbridge,
const JavaParamRef<jobject>& jprofile) {
RecentlyClosedTabsBridge* bridge = new RecentlyClosedTabsBridge(
+ ScopedJavaGlobalRef<jobject>(env, jbridge.obj()),
ProfileAndroid::FromProfileAndroid(jprofile));
return reinterpret_cast<intptr_t>(bridge);
}
« no previous file with comments | « chrome/browser/android/recently_closed_tabs_bridge.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698