Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: pkg/kernel/bin/dartk.dart

Issue 2610133002: Non-format-changing kernel offset changes (Closed)
Patch Set: End offset doesn't appear to be needed on AwaitExpression (anymore) Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/bin/dartk.dart
diff --git a/pkg/kernel/bin/dartk.dart b/pkg/kernel/bin/dartk.dart
index f6a6447472e6c781911225381fb20ed4e5f78bb4..77a12f1c32780101380a69392607ff5a0ac1aad4 100755
--- a/pkg/kernel/bin/dartk.dart
+++ b/pkg/kernel/bin/dartk.dart
@@ -75,7 +75,10 @@ ArgParser parser = new ArgParser(allowTrailingOptions: true)
hide: true)
..addFlag('show-external',
help: 'When printing a library as text, also print its dependencies\n'
- 'on external libraries.');
+ 'on external libraries.')
+ ..addFlag('show-offsets',
+ help: 'When printing a library as text, also print node offsets\n'
+ 'in file.');
Kevin Millikin (Google) 2017/01/04 14:36:58 I think 'in file' is implicit. I'd just leave it
jensj 2017/01/05 09:07:55 I'll delete it.
String getUsage() => """
Usage: dartk [options] FILE
@@ -376,7 +379,9 @@ Future<CompilerOutcome> batchMain(
switch (format) {
case 'text':
writeProgramToText(program,
- path: outputFile, showExternal: options['show-external']);
+ path: outputFile,
+ showExternal: options['show-external'],
+ showOffsets: options['show-offsets']);
break;
case 'bin':
ioFuture = writeProgramToBinary(program, outputFile);
« no previous file with comments | « no previous file | pkg/kernel/lib/analyzer/ast_from_analyzer.dart » ('j') | pkg/kernel/lib/analyzer/ast_from_analyzer.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698