Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_common.cc

Issue 261013010: autocomplete: add ability to get full address (hidden behind a flag). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: GCC weirdness Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_common.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_common.cc b/chrome/browser/ui/autofill/autofill_dialog_common.cc
index e95c9beafd2658030f2d47e22fa151db0bb1c952..85188d8a03c51064696b8d72e4c98395142ad566 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_common.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_common.cc
@@ -35,10 +35,11 @@ bool ServerTypeEncompassesFieldType(ServerFieldType type,
if (autofill_type.group() != field_type.group())
return false;
- // The page may ask for individual address lines; this roughly matches the
- // street address blob.
- if (server_type == ADDRESS_HOME_LINE1 || server_type == ADDRESS_HOME_LINE2)
+ // Street address (all lines) is matched to the first input address line.
+ if (server_type == ADDRESS_HOME_STREET_ADDRESS ||
Ilya Sherman 2014/05/07 01:19:19 This line seems redundant with line 44. Also, wha
Evan Stade 2014/05/09 22:14:59 woopsies, this is the result of a bad merge (I sta
+ field_type.html_type() == HTML_TYPE_FULL_ADDRESS) {
return autofill_type.GetStorableType() == ADDRESS_HOME_STREET_ADDRESS;
+ }
return autofill_type.GetStorableType() == server_type;
}

Powered by Google App Engine
This is Rietveld 408576698