Add test of ChromeVox in guest mode so we can't accidentally break it again.

Add test of ChromeVox in guest mode so we can't accidentally break it again.

BUG=362442
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268796

[Peter Lundblad, 2014-05-06 16:40:39]

https://codereview.chromium.org/261013009/diff/1/chrome/browser/chromeos/acce...
File chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
(right):

https://codereview.chromium.org/261013009/diff/1/chrome/browser/chromeos/acce...
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:135:
IN_PROC_BROWSER_TEST_F(GuestSpokenFeedbackTest, FocusToolbar) {
Did you consider parameterizing the test on user similar to what is done in
accessibility_manager_browsertest to make it easier to add critical regression
tests that would then be instantiated for all user type

[dmazzoni, 2014-05-06 22:05:39]

Good idea, I parameterized the test, take a look.


On Tue, May 6, 2014 at 9:40 AM, <plundblad@chromium.org> wrote:

>
>
>
>
> https://codereview.chromium.org/261013009/diff/1/chrome/browser/chromeos/
> accessibility/spoken_feedback_browsertest.cc
> File
> chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
> (right):
>
> https://codereview.chromium.org/261013009/diff/1/chrome/browser/chromeos/
> accessibility/spoken_feedback_browsertest.cc#newcode135
> chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:135:
> IN_PROC_BROWSER_TEST_F(GuestSpokenFeedbackTest, FocusToolbar) {
> Did you consider parameterizing the test on user similar to what is done
> in accessibility_manager_browsertest to make it easier to add critical
> regression tests that would then be instantiated for all user type
>
> https://codereview.chromium.org/261013009/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Lundblad, 2014-05-06 23:00:49]

lgtm

Cool!

[dmazzoni, 2014-05-06 23:03:00]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-05-06 23:05:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/261013009/20001

[commit-bot: I haz the power, 2014-05-07 16:07:24]

Change committed as 268796