Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 261013008: Changes color scheme of alt keys. (Closed)

Created:
6 years, 7 months ago by rsadam
Modified:
6 years, 7 months ago
Reviewers:
bshe
CC:
chromium-reviews
Visibility:
Public.

Description

Changes color scheme of alt keys. BUG=364468 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268281

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M ui/keyboard/resources/elements/kb-altkey.html View 3 chunks +6 lines, -2 lines 0 comments Download
M ui/keyboard/resources/elements/kb-altkey-container.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/keyboard/resources/elements/kb-altkey-set.html View 1 chunk +3 lines, -1 line 0 comments Download
M ui/keyboard/resources/elements/kb-key.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
rsadam
Final CL for getting the two keyboard skinned the same - PTAL!
6 years, 7 months ago (2014-05-02 19:45:44 UTC) #1
bshe
lgtm https://codereview.chromium.org/261013008/diff/1/ui/keyboard/resources/elements/kb-altkey-container.html File ui/keyboard/resources/elements/kb-altkey-container.html (right): https://codereview.chromium.org/261013008/diff/1/ui/keyboard/resources/elements/kb-altkey-container.html#newcode13 ui/keyboard/resources/elements/kb-altkey-container.html:13: background-color: rgba(0, 0, 0, 0); background color should ...
6 years, 7 months ago (2014-05-02 20:06:41 UTC) #2
rsadam
Fixed nit! https://codereview.chromium.org/261013008/diff/1/ui/keyboard/resources/elements/kb-altkey-container.html File ui/keyboard/resources/elements/kb-altkey-container.html (right): https://codereview.chromium.org/261013008/diff/1/ui/keyboard/resources/elements/kb-altkey-container.html#newcode13 ui/keyboard/resources/elements/kb-altkey-container.html:13: background-color: rgba(0, 0, 0, 0); On 2014/05/02 ...
6 years, 7 months ago (2014-05-05 14:54:31 UTC) #3
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 7 months ago (2014-05-05 14:54:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/261013008/20001
6 years, 7 months ago (2014-05-05 14:55:22 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-05 18:17:24 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 21:53:00 UTC) #7
Message was sent while issue was closed.
Change committed as 268281

Powered by Google App Engine
This is Rietveld 408576698