Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Unified Diff: Source/wtf/text/TextCodecReplacement.cpp

Issue 261013007: Prevent direct use of "replacement" text encoding. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: MSVC fix Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/encoding/TextDecoder.cpp ('k') | Source/wtf/text/TextCodecReplacementTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/wtf/text/TextCodecReplacement.cpp
diff --git a/Source/wtf/text/TextCodecReplacement.cpp b/Source/wtf/text/TextCodecReplacement.cpp
index ca9373abd77b70b99b9aca968be458fecab1ad36..c6ec52fd9ae5bf05139da09654dc5284c84e3530 100644
--- a/Source/wtf/text/TextCodecReplacement.cpp
+++ b/Source/wtf/text/TextCodecReplacement.cpp
@@ -18,10 +18,10 @@ TextCodecReplacement::TextCodecReplacement()
void TextCodecReplacement::registerEncodingNames(EncodingNameRegistrar registrar)
{
- // FIXME: The 'replacement' label itself should not be referenceable by
+ // The 'replacement' label itself should not be referenceable by
// resources or script - it's a specification convenience - but much of
// the wtf/text API asserts that an encoding name is a label for itself.
- // crbug.com/277037
+ // This is handled in TextEncoding by marking it as not valid.
registrar("replacement", "replacement");
registrar("csiso2022kr", "replacement");
« no previous file with comments | « Source/modules/encoding/TextDecoder.cpp ('k') | Source/wtf/text/TextCodecReplacementTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698