Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(238)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/fast/encoding/api/replacement-encoding-expected.txt
Issue
261013007
:
Prevent direct use of "replacement" text encoding. (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: MSVC fix
Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/fast/encoding/api/replacement-encoding.html
LayoutTests/fast/encoding/api/replacement-encoding-expected.txt
LayoutTests/fast/encoding/charset-replacement-expected.txt
LayoutTests/platform/linux/fast/encoding/charset-replacement-expected.png
LayoutTests/platform/mac/fast/encoding/charset-replacement-expected.png
LayoutTests/platform/mac/fast/encoding/charset-replacement-expected.txt
LayoutTests/platform/win-xp/fast/encoding/charset-replacement-expected.png
LayoutTests/platform/win-xp/fast/encoding/charset-replacement-expected.txt
LayoutTests/platform/win/fast/encoding/charset-replacement-expected.png
Source/modules/encoding/TextDecoder.cpp
Source/wtf/text/TextCodecReplacement.cpp
Source/wtf/text/TextCodecReplacementTest.cpp
Source/wtf/text/TextEncoding.cpp
Source/wtf/text/TextEncodingRegistry.h
Source/wtf/text/TextEncodingRegistry.cpp
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« LayoutTests/fast/encoding/api/replacement-encoding.html
('k') |
LayoutTests/fast/encoding/charset-replacement-expected.txt »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
This is a testharness.js-based test.
2
PASS The "replacement" label should not be a known encoding.
3
PASS Label for "replacement" should be rejected by API: csiso2022kr
4
PASS Label for "replacement" should be rejected by API: hz-gb-2312
5
PASS Label for "replacement" should be rejected by API: iso-2022-cn
6
PASS Label for "replacement" should be rejected by API: iso-2022-cn-ext
7
PASS Label for "replacement" should be rejected by API: iso-2022-kr
8
Harness: the test ran to completion.
9
OLD
NEW
« no previous file with comments
|
« LayoutTests/fast/encoding/api/replacement-encoding.html
('k') |
LayoutTests/fast/encoding/charset-replacement-expected.txt »
('j') |
no next file with comments »
Issue 261013007: Prevent direct use of "replacement" text encoding. (Closed)
Created 6 years, 7 months ago by jsbell
Modified 6 years, 7 months ago
Reviewers: eseidel, jungshik at Google
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 261013007:
Prevent direct use of "replacement" text encoding. (Closed)
Base URL: svn://svn.chromium.org/blink/trunk