Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest_manager.h

Issue 261013005: BrowserPlugin: Move CreateGuest to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_simplify_api
Patch Set: Fixed content_browsertests after a change Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest_manager.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest_manager.h b/content/browser/browser_plugin/browser_plugin_guest_manager.h
index 31210dd89e7b1406bd5a8288170cddff1d2c4d8f..55106400a786580dd00bfd122dc7f407c815c68e 100644
--- a/content/browser/browser_plugin/browser_plugin_guest_manager.h
+++ b/content/browser/browser_plugin/browser_plugin_guest_manager.h
@@ -65,19 +65,13 @@ class CONTENT_EXPORT BrowserPluginGuestManager :
// If params.src is present, the new guest will also be navigated to the
// provided URL. Optionally, the new guest may be attached to a
// |guest_opener|, and may be attached to a pre-selected |routing_id|.
- BrowserPluginGuest* CreateGuest(
+ virtual BrowserPluginGuest* CreateGuest(
SiteInstance* embedder_site_instance,
int instance_id,
- const BrowserPluginHostMsg_Attach_Params& params,
+ const std::string& storage_partition_id,
+ bool persist_storage,
scoped_ptr<base::DictionaryValue> extra_params);
- // Adds a new |guest_web_contents| to the embedder (overridable in test).
- virtual void AddGuest(int instance_id, WebContents* guest_web_contents);
-
- // Removes the guest with the given |instance_id| from this
- // BrowserPluginGuestManager.
- void RemoveGuest(int instance_id);
-
typedef base::Callback<void(BrowserPluginGuest*)> GuestByInstanceIDCallback;
void MaybeGetGuestByInstanceIDOrKill(
int instance_id,
@@ -95,10 +89,6 @@ class CONTENT_EXPORT BrowserPluginGuestManager :
explicit BrowserPluginGuestManager(BrowserContext* context);
- // Returns an existing SiteInstance if the current profile has a guest of the
- // given |guest_site|.
- SiteInstance* GetGuestSiteInstance(const GURL& guest_site);
-
// Static factory instance (always NULL outside of tests).
static BrowserPluginHostFactory* factory_;
« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/browser/browser_plugin/browser_plugin_guest_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698