content/browser/browser_plugin/browser_plugin_embedder.cc - Issue 261013005: BrowserPlugin: Move CreateGuest to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.cc

Issue 261013005: BrowserPlugin: Move CreateGuest to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_simplify_api

Patch Set: Fixed content_browsertests after a change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/browser_plugin/browser_plugin_embedder.cc

diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc

index 3591decaaf9592fc0b056c6ef8fed07102b15ec2..7f2a4f7addd26e151b82d979d4dca01b838f99e0 100644

--- a/content/browser/browser_plugin/browser_plugin_embedder.cc

+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc

@@ -189,10 +189,11 @@ void BrowserPluginEmbedder::OnGuestCallback(

}

scoped_ptr<base::DictionaryValue> copy_extra_params(extra_params->DeepCopy());

- guest = guest_manager->CreateGuest(

- GetWebContents()->GetSiteInstance(),

- instance_id, params,

- copy_extra_params.Pass());

+ guest = guest_manager->CreateGuest(GetWebContents()->GetSiteInstance(),

+ instance_id,

+ params.storage_partition_id,

+ params.persist_storage,

+ copy_extra_params.Pass());

if (guest) {

GetContentClient()->browser()->GuestWebContentsAttached(

guest->GetWebContents(),

« no previous file with comments | « chrome/browser/guest_view/guest_view_manager.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »