Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3867)

Unified Diff: chrome/browser/guest_view/guest_view_manager.h

Issue 261013005: BrowserPlugin: Move CreateGuest to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_simplify_api
Patch Set: Fixed content_browsertests after a change Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/guest_view/guest_view_base.cc ('k') | chrome/browser/guest_view/guest_view_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guest_view/guest_view_manager.h
diff --git a/chrome/browser/guest_view/guest_view_manager.h b/chrome/browser/guest_view/guest_view_manager.h
index b26ae9c89e78b60b2ab16e5fad606daf5c13e969..6a18d1a3231583cb717ec39d191376aba699672f 100644
--- a/chrome/browser/guest_view/guest_view_manager.h
+++ b/chrome/browser/guest_view/guest_view_manager.h
@@ -39,24 +39,34 @@ class GuestViewManager : public content::BrowserPluginGuestManagerDelegate,
int embedder_render_process_id);
// BrowserPluginGuestManagerDelegate implementation.
+ virtual content::WebContents* CreateGuest(
+ content::SiteInstance* embedder_site_instance,
+ int instance_id,
+ const std::string& storage_partition_id,
+ bool persist_storage,
+ scoped_ptr<base::DictionaryValue> extra_params) OVERRIDE;
virtual int GetNextInstanceID() OVERRIDE;
- virtual void AddGuest(int guest_instance_id,
- content::WebContents* guest_web_contents) OVERRIDE;
- virtual void RemoveGuest(int guest_instance_id) OVERRIDE;
virtual void MaybeGetGuestByInstanceIDOrKill(
int guest_instance_id,
int embedder_render_process_id,
const GuestByInstanceIDCallback& callback) OVERRIDE;
- virtual content::SiteInstance* GetGuestSiteInstance(
- const GURL& guest_site) OVERRIDE;
virtual bool ForEachGuest(content::WebContents* embedder_web_contents,
const GuestCallback& callback) OVERRIDE;
private:
+ friend class GuestViewBase;
friend class GuestWebContentsObserver;
+ void AddGuest(int guest_instance_id,
+ content::WebContents* guest_web_contents);
+
+ void RemoveGuest(int guest_instance_id);
+
void AddRenderProcessHostID(int render_process_host_id);
+ content::SiteInstance* GetGuestSiteInstance(
+ const GURL& guest_site);
+
content::WebContents* GetGuestByInstanceID(
int guest_instance_id,
int embedder_render_process_id);
« no previous file with comments | « chrome/browser/guest_view/guest_view_base.cc ('k') | chrome/browser/guest_view/guest_view_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698