Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: content/shell/browser/browser_plugin/test_guest_manager_delegate.h

Issue 261013005: BrowserPlugin: Move CreateGuest to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_simplify_api
Patch Set: Removed AddGuest/RemoveGuest from content API! w00t! Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/browser_plugin/test_guest_manager_delegate.h
diff --git a/content/shell/browser/browser_plugin/test_guest_manager_delegate.h b/content/shell/browser/browser_plugin/test_guest_manager_delegate.h
index 6b6beaf20d3a857bf182bf3e3d0b20ebc0c19e6e..d313711f38ddc0b19b4dde2345bb858f56323056 100644
--- a/content/shell/browser/browser_plugin/test_guest_manager_delegate.h
+++ b/content/shell/browser/browser_plugin/test_guest_manager_delegate.h
@@ -20,17 +20,21 @@ class TestGuestManagerDelegate : public BrowserPluginGuestManagerDelegate {
static TestGuestManagerDelegate* GetInstance();
+ void AddGuest(int guest_instance_id, WebContents* guest_web_contents);
+ void RemoveGuest(int guest_instance_id);
+ SiteInstance* GetGuestSiteInstance(const GURL& guest_site);
+
// BrowserPluginGuestManagerDelegate implementation.
+ virtual content::WebContents* CreateGuest(
+ content::SiteInstance* embedder_site_instance,
+ int instance_id,
+ const StorageInfo& storage_info,
+ scoped_ptr<base::DictionaryValue> extra_params) OVERRIDE;
virtual int GetNextInstanceID() OVERRIDE;
- virtual void AddGuest(int guest_instance_id,
- WebContents* guest_web_contents) OVERRIDE;
- virtual void RemoveGuest(int guest_instance_id) OVERRIDE;
virtual void MaybeGetGuestByInstanceIDOrKill(
int guest_instance_id,
int embedder_render_process_id,
const GuestByInstanceIDCallback& callback) OVERRIDE;
- virtual SiteInstance* GetGuestSiteInstance(
- const GURL& guest_site) OVERRIDE;
virtual bool ForEachGuest(WebContents* embedder_web_contents,
const GuestCallback& callback) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698