content/public/browser/browser_plugin_guest_manager_delegate.cc - Issue 261013005: BrowserPlugin: Move CreateGuest to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/browser_plugin_guest_manager_delegate.cc

Issue 261013005: BrowserPlugin: Move CreateGuest to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_simplify_api

Patch Set: Removed AddGuest/RemoveGuest from content API! w00t! Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/public/browser/browser_plugin_guest_manager_delegate.h ('k') | content/public/browser/web_contents.h » ('j') | content/public/browser/web_contents.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/browser_plugin_guest_manager_delegate.cc

diff --git a/content/public/browser/browser_plugin_guest_manager_delegate.cc b/content/public/browser/browser_plugin_guest_manager_delegate.cc

index e75730e4d0da72077cef64da5f3cfd54153be3c6..8bf5ced679c9687c91725c3baecb39882cf64e81 100644

--- a/content/public/browser/browser_plugin_guest_manager_delegate.cc

+++ b/content/public/browser/browser_plugin_guest_manager_delegate.cc

@@ -7,13 +7,16 @@

namespace content {

-int BrowserPluginGuestManagerDelegate::GetNextInstanceID() {

- return 0;

+content::WebContents* BrowserPluginGuestManagerDelegate::CreateGuest(

+ SiteInstance* embedder_site_instance,

+ int instance_id,

+ const StorageInfo& storage_info,

+ scoped_ptr<base::DictionaryValue> extra_params) {

+ return NULL;

}

-content::SiteInstance* BrowserPluginGuestManagerDelegate::GetGuestSiteInstance(

- const GURL& guest_site) {

- return NULL;

+int BrowserPluginGuestManagerDelegate::GetNextInstanceID() {

+ return 0;

}

bool BrowserPluginGuestManagerDelegate::ForEachGuest(