content/browser/web_contents/web_contents_impl.h - Issue 261013005: BrowserPlugin: Move CreateGuest to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 261013005: BrowserPlugin: Move CreateGuest to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_simplify_api

Patch Set: Removed AddGuest/RemoveGuest from content API! w00t! Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_plugin/browser_plugin_guest.cc ('K') | « content/browser/browser_plugin/test_browser_plugin_guest_manager.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 06882f99ac33da585a9e6bad91880d3cabdce483..e42dba14a7c1df25a8ea49d700c5927579bac26b 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -100,13 +100,6 @@ class CONTENT_EXPORT WebContentsImpl

// opener is closed or the page clears its window.opener.

WebContentsImpl* opener() const { return opener_; }

- // Creates a WebContents to be used as a browser plugin guest.

- static BrowserPluginGuest* CreateGuest(

- BrowserContext* browser_context,

- content::SiteInstance* site_instance,

- int guest_instance_id,

- scoped_ptr<base::DictionaryValue> extra_params);

// Creates a swapped out RenderView. This is used by the browser plugin to

// create a swapped out RenderView in the embedder render process for the

// guest, to expose the guest's window object to the embedder.