content/browser/browser_plugin/browser_plugin_embedder.cc - Issue 261013005: BrowserPlugin: Move CreateGuest to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.cc

Issue 261013005: BrowserPlugin: Move CreateGuest to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_simplify_api

Patch Set: Removed AddGuest/RemoveGuest from content API! w00t! Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/guest_view/guest_view_manager.cc ('K') | « chrome/browser/guest_view/guest_view_manager.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | content/browser/browser_plugin/browser_plugin_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_embedder.cc

diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc

index 207a5c5859a4172d0adb3f5b8558eb11132d403f..c4e5472925df5e2d886b2814b0db9e0f5ff45125 100644

--- a/content/browser/browser_plugin/browser_plugin_embedder.cc

+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc

@@ -187,9 +187,12 @@ void BrowserPluginEmbedder::GuestCallback(

}

scoped_ptr<base::DictionaryValue> copy_extra_params(extra_params->DeepCopy());

+ StorageInfo storage_info;

+ storage_info.partition_id = params.storage_partition_id;

+ storage_info.persist = params.persist_storage;

guest = guest_manager->CreateGuest(

GetWebContents()->GetSiteInstance(),

- instance_id, params,

+ instance_id, storage_info,

copy_extra_params.Pass());

if (guest) {

GetContentClient()->browser()->GuestWebContentsAttached(