content/browser/renderer_host/render_process_host_impl.cc - Issue 261013005: BrowserPlugin: Move CreateGuest to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 261013005: BrowserPlugin: Move CreateGuest to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_simplify_api

Patch Set: Removed unnecessary includes Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/test_guest_manager_delegate.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_process_host_impl.cc

diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc

index 7d19b6f55387aa80794b08a7193c75ae3a31505c..30c8c29b405424da01369f286174da9ada2cd651 100644

--- a/content/browser/renderer_host/render_process_host_impl.cc

+++ b/content/browser/renderer_host/render_process_host_impl.cc

@@ -1585,12 +1585,7 @@ void RenderProcessHostImpl::FilterURL(RenderProcessHost* rph,

RecordAction(base::UserMetricsAction("FilterURLTermiate_About"));

}

- // Do not allow browser plugin guests to navigate to non-web URLs, since they

- // cannot swap processes or grant bindings.

- bool non_web_url_in_guest = rph->IsGuest() &&

- !(url->is_valid() && policy->IsWebSafeScheme(url->scheme()));

- if (non_web_url_in_guest || !policy->CanRequestURL(rph->GetID(), *url)) {

+ if (!policy->CanRequestURL(rph->GetID(), *url)) {

// If this renderer is not permitted to request this URL, we invalidate the

// URL. This prevents us from storing the blocked URL and becoming confused

// later.