Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 261013004: Allow use of EGL in browser tests with --use-gl=egl. (Closed)

Created:
6 years, 7 months ago by danakj
Modified:
6 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, no sievers
Visibility:
Public.

Description

Allow use of EGL in browser tests with --use-gl=egl. Browser tests on some ARM devices need to use EGL, but our browser tests do not currently allow the use of --use-gl and they default to GLX. Allow the use of --use-gl, but have browser tests override it with the --override-use-gl-with-osmesa-for-tests flag by default, this ensures that --use-gl on its own does not change the behaviour of the tests. The --use-gpu-in-tests flag allows the --use-gl flag to take effect, as the browser tests will try to use hardware gpu then. R=piman BUG=364729 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267882

Patch Set 1 #

Total comments: 2

Patch Set 2 : egl-browsertests: #

Total comments: 1

Patch Set 3 : egl-browsertests: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/browser_test_base.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M ui/gl/gl_surface.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gl/gl_switches.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/gl/gl_switches.cc View 1 2 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
danakj
6 years, 7 months ago (2014-05-01 20:36:00 UTC) #1
piman
https://codereview.chromium.org/261013004/diff/1/content/public/test/browser_test_base.cc File content/public/test/browser_test_base.cc (right): https://codereview.chromium.org/261013004/diff/1/content/public/test/browser_test_base.cc#newcode221 content/public/test/browser_test_base.cc:221: command_line->AppendSwitch(switches::kOverrideUseGLWithOSMesaForTests); You need to add this to GpuProcessHost so ...
6 years, 7 months ago (2014-05-01 20:41:20 UTC) #2
danakj
https://codereview.chromium.org/261013004/diff/1/content/public/test/browser_test_base.cc File content/public/test/browser_test_base.cc (right): https://codereview.chromium.org/261013004/diff/1/content/public/test/browser_test_base.cc#newcode221 content/public/test/browser_test_base.cc:221: command_line->AppendSwitch(switches::kOverrideUseGLWithOSMesaForTests); On 2014/05/01 20:41:20, piman wrote: > You need ...
6 years, 7 months ago (2014-05-01 20:53:49 UTC) #3
piman
lgtm https://codereview.chromium.org/261013004/diff/20001/ui/gl/gl_switches.cc File ui/gl/gl_switches.cc (right): https://codereview.chromium.org/261013004/diff/20001/ui/gl/gl_switches.cc#newcode81 ui/gl/gl_switches.cc:81: kOverrideUseGLWithOSMesaForTests, o_O
6 years, 7 months ago (2014-05-01 20:55:34 UTC) #4
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-02 16:50:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/261013004/40001
6 years, 7 months ago (2014-05-02 16:52:48 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 18:36:04 UTC) #7
Message was sent while issue was closed.
Change committed as 267882

Powered by Google App Engine
This is Rietveld 408576698