Add overrides for BookmarkModel clipboard interface on iOS

Add overrides for BookmarkModel clipboard interface on iOS

Chrome on iOS does not support the clipboard, so install overrides that
disable the clipboard on iOS and disable the corresponding unit tests.

BUG=228147
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268283

[blundell, 2014-05-05 12:32:18]

https://codereview.chromium.org/261013002/diff/20001/components/bookmarks.gypi
File components/bookmarks.gypi (right):

https://codereview.chromium.org/261013002/diff/20001/components/bookmarks.gyp...
components/bookmarks.gypi:48:
'bookmarks/core/browser/bookmark_pasteboard_helper_ios.cc',
this should be bookmark_node_data_ios.cc

https://codereview.chromium.org/261013002/diff/20001/components/bookmarks/cor...
File components/bookmarks/core/browser/bookmark_node_data.cc (right):

https://codereview.chromium.org/261013002/diff/20001/components/bookmarks/cor...
components/bookmarks/core/browser/bookmark_node_data.cc:115: #if
!defined(OS_MACOSX) && !defined(OS_IOS)
This is unnecessary: OS_MACOSX is defined when OS_IOS is defined.

[noyau (Ping after 24h), 2014-05-05 13:42:23]

https://codereview.chromium.org/261013002/diff/20001/components/bookmarks/cor...
File components/bookmarks/core/browser/bookmark_node_data_ios.cc (right):

https://codereview.chromium.org/261013002/diff/20001/components/bookmarks/cor...
components/bookmarks/core/browser/bookmark_node_data_ios.cc:9: }
Should this be a NOTREACHED()?

[blundell, 2014-05-05 13:44:18]

On 2014/05/05 13:42:23, noyau wrote:
>
https://codereview.chromium.org/261013002/diff/20001/components/bookmarks/cor...
> File components/bookmarks/core/browser/bookmark_node_data_ios.cc (right):
> 
>
https://codereview.chromium.org/261013002/diff/20001/components/bookmarks/cor...
> components/bookmarks/core/browser/bookmark_node_data_ios.cc:9: }
> Should this be a NOTREACHED()?

I don't know if these functions are called on iOS or not offhand.

[sdefresne, 2014-05-05 14:45:49]

PTAL

https://codereview.chromium.org/261013002/diff/20001/components/bookmarks.gypi
File components/bookmarks.gypi (right):

https://codereview.chromium.org/261013002/diff/20001/components/bookmarks.gyp...
components/bookmarks.gypi:48:
'bookmarks/core/browser/bookmark_pasteboard_helper_ios.cc',
On 2014/05/05 12:32:18, blundell wrote:
> this should be bookmark_node_data_ios.cc

Done.

https://codereview.chromium.org/261013002/diff/20001/components/bookmarks/cor...
File components/bookmarks/core/browser/bookmark_node_data.cc (right):

https://codereview.chromium.org/261013002/diff/20001/components/bookmarks/cor...
components/bookmarks/core/browser/bookmark_node_data.cc:115: #if
!defined(OS_MACOSX) && !defined(OS_IOS)
On 2014/05/05 12:32:18, blundell wrote:
> This is unnecessary: OS_MACOSX is defined when OS_IOS is defined.

Done.

https://codereview.chromium.org/261013002/diff/20001/components/bookmarks/cor...
File components/bookmarks/core/browser/bookmark_node_data_ios.cc (right):

https://codereview.chromium.org/261013002/diff/20001/components/bookmarks/cor...
components/bookmarks/core/browser/bookmark_node_data_ios.cc:9: }
On 2014/05/05 13:42:23, noyau wrote:
> Should this be a NOTREACHED()?

Done.

[blundell, 2014-05-05 14:47:47]

LGTM

[noyau (Ping after 24h), 2014-05-05 14:52:27]

lgtm

[sdefresne, 2014-05-05 17:53:45]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-05-05 17:54:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sdefresne@chromium.org/261013002/40001

[commit-bot: I haz the power, 2014-05-05 21:54:38]

Change committed as 268283