Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp

Issue 2610063006: Create TaskAttributionTiming PerformanceEntry for attribution in PerformanceLongTaskTiming. Move cu… (Closed)
Patch Set: update layout test expectation Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp b/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
index 6b9032c647c9b6071fc0a6423dfbec676c70ceef..448b4780d91439c79c402b78ace6920d4d1812a4 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
@@ -5,6 +5,7 @@
#include "core/timing/PerformanceLongTaskTiming.h"
#include "core/frame/DOMWindow.h"
+#include "core/timing/TaskAttributionTiming.h"
namespace blink {
@@ -17,6 +18,17 @@ double clampToMillisecond(double timeInMillis) {
} // namespace
+// static
+PerformanceLongTaskTiming* PerformanceLongTaskTiming::create(double startTime,
+ double endTime,
+ String name,
+ String frameSrc,
+ String frameId,
+ String frameName) {
+ return new PerformanceLongTaskTiming(startTime, endTime, name, frameSrc,
+ frameId, frameName);
+}
+
PerformanceLongTaskTiming::PerformanceLongTaskTiming(double startTime,
double endTime,
String name,
@@ -26,26 +38,21 @@ PerformanceLongTaskTiming::PerformanceLongTaskTiming(double startTime,
: PerformanceEntry(name,
"longtask",
clampToMillisecond(startTime),
- clampToMillisecond(endTime)),
- m_culpritFrameSrc(culpritFrameSrc),
- m_culpritFrameId(culpritFrameId),
- m_culpritFrameName(culpritFrameName) {}
-
-PerformanceLongTaskTiming::~PerformanceLongTaskTiming() {}
-
-String PerformanceLongTaskTiming::culpritFrameSrc() const {
- return m_culpritFrameSrc;
+ clampToMillisecond(endTime)) {
+ // Only one possible name ("frame") currently.
+ TaskAttributionTiming* attributionEntry = TaskAttributionTiming::create(
+ "frame", culpritFrameSrc, culpritFrameId, culpritFrameName);
+ m_attribution.append(*attributionEntry);
}
-String PerformanceLongTaskTiming::culpritFrameId() const {
- return m_culpritFrameId;
-}
+PerformanceLongTaskTiming::~PerformanceLongTaskTiming() {}
-String PerformanceLongTaskTiming::culpritFrameName() const {
- return m_culpritFrameName;
+TaskAttributionVector PerformanceLongTaskTiming::attribution() const {
+ return m_attribution;
}
DEFINE_TRACE(PerformanceLongTaskTiming) {
+ visitor->trace(m_attribution);
PerformanceEntry::trace(visitor);
}

Powered by Google App Engine
This is Rietveld 408576698