Add ContentCache.getExists() and use it in AnalysisContextImpl.exists().

pkg/analyzer/lib/src/generated/source.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.generated.source;
 
 import 'dart:collection';
 import "dart:math" as math;
 
 import 'package:analyzer/file_system/file_system.dart';
@@ skipping 48 matching lines @@
   /**
    * Return the contents of the given [source], or `null` if this cache does not
    * override the contents of the source.
    *
    * <b>Note:</b> This method is not intended to be used except by
    * [AnalysisContext.getContents].
    */
   String getContents(Source source) => _contentMap[source.fullName];
 
   /**
+   * Return `true` if the given [source] exists, `false` if it does not exist,
+   * or `null` if this cache does not override existence of the source.

[Paul Berry, 2017/01/04 18:28:57]

It looks like you are trying to plan ahead to a possible future where we might
want the content cache to be able to represent a deletion (i.e. the source
actually exists on disk but the content cache wants to pretend it doesn't).  But
this possible future doesn't exist yet (which is why the code below always
returns either `true` or `null`.

I find this really confusing, and it's hard to test well because we can't easily
write unit tests to exercise a feature that doesn't exist yet.

My recommendation: change this code so that it returns `true` if the given
source is overridden in the content cache, and `false` if it is not overridden. 
Then the implementation just becomes `return
_contentMap.containsKey(source.fullName);` and the caller can be changed the way
I mentioned earlier.

[scheglov, 2017/01/04 20:07:27]

I'm trying to extend ContentCache to fully control AnalysisContext's view of the
world.
So, we can provide a view of the world in the new analysis driver.
We don't want an AnalysisContext to talk to any Source directly.
So, we cannot do contentCache.getExists() || source.exists().

We already have this model for getContents() - it returns a value, or null as "I
don't know".

+   *
+   * <b>Note:</b> This method is not intended to be used except by
+   * [AnalysisContext.exists].
+   */
+  bool getExists(Source source) {
+    return _contentMap.containsKey(source.fullName) ? true : null;

[Brian Wilkerson, 2017/01/04 18:05:10]

Did you intend to return `null` rather than `false`?

+  }
+
+  /**
    * Return the modification stamp of the given [source], or `null` if this
    * cache does not override the contents of the source.
    *
    * <b>Note:</b> This method is not intended to be used except by
    * [AnalysisContext.getModificationStamp].
    */
   int getModificationStamp(Source source) => _stampMap[source.fullName];
 
   /**
    * Set the contents of the given [source] to the given [contents]. This has
@@ skipping 663 matching lines @@
   Source resolveAbsolute(Uri uri, [Uri actualUri]);
 
   /**
    * Return an absolute URI that represents the given [source], or `null` if a
    * valid URI cannot be computed.
    *
    * The computation should be based solely on [source.fullName].
    */
   Uri restoreAbsolute(Source source) => null;
 }