Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 261003002: Drop obsolete HCheckMaps::HandleSideEffectsDominator(). (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Drop obsolete HCheckMaps::HandleSideEffectsDominator(). In HCheckMaps::HandleSideEffectsDominator() we try to remove redundant HCheckMaps instructions that are dominated by an HStoreNamedField instruction with a transition. This is just a special case of the check elimination and therefore obsolete (it also gives some nice speedup since GVN just got cheaper). R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M src/hydrogen-instructions.h View 4 chunks +1 line, -4 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Because fast! :-)
6 years, 7 months ago (2014-05-01 11:28:51 UTC) #1
Sven Panne
lgtm
6 years, 7 months ago (2014-05-02 05:53:49 UTC) #2
Benedikt Meurer
6 years, 7 months ago (2014-05-02 05:59:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21108 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698