Use the function name as the location for a missing return error.

Use the function name as the location for a missing return error.

Previously, it was using the entire function node, including it's body,
which makes for a gratuitously large amount of red squiggles. :)

This uses the function's name instead. As a side effect, the error now
appears a little later for a getter:

  get foo => ...
      ^^^

Where before it was:

  get foo => ...
  ^^^^^^^^^^^^^^

I tried putting the span on "get" instead in this case because that's
closer to where the return type should go, but I think the name looks a
little better because that's the name mentioned in the error message
too.

R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/da16354b1bf7cf86d9ab3aae9fa0e98633b327fe

[Bob Nystrom, 2017-01-03 21:01:39]

rnystrom@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2017-01-04 02:01:22]

LGTM, much nicer!

[Bob Nystrom, 2017-01-04 18:18:13]

Description was changed from

==========
Use the function name as the location for a missing return error.

Previously, it was using the entire function node, including it's body,
which makes for a gratuitously large amount of red squiggles. :)

This uses the function's name instead. As a side effect, the error now
appears a little later for a getter:

  get foo => ...
      ^^^

Where before it was:

  get foo => ...
  ^^^^^^^^^^^^^^

I tried putting the span on "get" instead in this case because that's
closer to where the return type should go, but I think the name looks a
little better because that's the name mentioned in the error message
too.
==========

to

==========
Use the function name as the location for a missing return error.

Previously, it was using the entire function node, including it's body,
which makes for a gratuitously large amount of red squiggles. :)

This uses the function's name instead. As a side effect, the error now
appears a little later for a getter:

  get foo => ...
      ^^^

Where before it was:

  get foo => ...
  ^^^^^^^^^^^^^^

I tried putting the span on "get" instead in this case because that's
closer to where the return type should go, but I think the name looks a
little better because that's the name mentioned in the error message
too.

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/da16354b1bf7cf86d9ab3aae9fa0e98633b327fe
==========

[Bob Nystrom, 2017-01-04 18:18:15]

Committed patchset #1 (id:1) manually as
da16354b1bf7cf86d9ab3aae9fa0e98633b327fe (presubmit successful).