src/compiler/js-builtin-reducer.cc - Issue 2609913002: [builtins] throw if TypedArray buffer is detached during iteration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-builtin-reducer.cc

Issue 2609913002: [builtins] throw if TypedArray buffer is detached during iteration (Closed)

Patch Set: maybe fix the test Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-builtin-reducer.cc

diff --git a/src/compiler/js-builtin-reducer.cc b/src/compiler/js-builtin-reducer.cc

index e3e0c78189b4783733bab4d97b7390205b22adda..6698408f94b5778e49a0decd4688215e788e8c07 100644

--- a/src/compiler/js-builtin-reducer.cc

+++ b/src/compiler/js-builtin-reducer.cc

@@ -557,7 +557,7 @@ Reduction JSBuiltinReducer::ReduceTypedArrayIteratorNext(

dependencies()->AssumePropertyCell(

factory()->array_buffer_neutering_protector());

} else {

- // Deoptimize if the array byuffer was neutered.

+ // Deoptimize if the array buffer was neutered.

Node* check1 = efalse0 = graph()->NewNode(

simplified()->ArrayBufferWasNeutered(), buffer, efalse0, if_false0);

check1 = graph()->NewNode(simplified()->BooleanNot(), check1);