third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h - Issue 2609883003: [wrapper-tracing] Avoid firing the write barrier after TraceEpilogue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h

Issue 2609883003: [wrapper-tracing] Avoid firing the write barrier after TraceEpilogue (Closed)

Patch Set: Fix tests: Wrap testing code with TracePrologue and AbortTracing Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp ('k') | third_party/WebKit/Source/platform/heap/WrapperVisitor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h

index c840a7b42ed5df934b9b47c08ecdc16424294a0d..4706b0dac75fab03ed96b60da2c0b8ecab83268d 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h

@@ -36,7 +36,7 @@ class ScriptWrappableVisitorVerifier : public WrapperVisitor {

}

void markWrapper(const v8::PersistentBase<v8::Value>*) const override {}

- void pushToMarkingDeque(

+ bool pushToMarkingDeque(

void (*traceWrappersCallback)(const WrapperVisitor*, const void*),

HeapObjectHeader* (*heapObjectHeaderCallback)(const void*),

const void* object) const override {

@@ -54,6 +54,7 @@ class ScriptWrappableVisitorVerifier : public WrapperVisitor {

NOTREACHED();

}

traceWrappersCallback(this, object);

+ return true;

}

bool markWrapperHeader(HeapObjectHeader* header) const override {