third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js - Issue 2609863005: [Devtools] Fixed undefined type in Network Waterfall for Other types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2609863005: [Devtools] Fixed undefined type in Network Waterfall for Other types (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

index bff7d1641d83bc72a1b777679da7abdea7a808dd..562b56e5c2d6fedee93a5db88b50ff56684ddaae 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

@@ -837,7 +837,7 @@ Network.NetworkLogView = class extends UI.VBox {

var request = node.request();

// TODO(allada) Make this dynamic and allow multiple grouping types.

- var groupKey = request.domain;

+ var groupKey = request.connectionId;

dgozman 2017/01/09 23:59:51 Unrelated?

var group = this._nodeGroups.get(groupKey);

if (group)

return group;

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js » ('j') | no next file with comments »