Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2609863005: [Devtools] Fixed undefined type in Network Waterfall for Other types (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 819 matching lines...) Expand 10 before | Expand all | Expand 10 after
830 /** 830 /**
831 * @param {!Network.NetworkRequestNode} node 831 * @param {!Network.NetworkRequestNode} node
832 * @return {!Network.NetworkNode} 832 * @return {!Network.NetworkNode}
833 */ 833 */
834 _parentNodeForInsert(node) { 834 _parentNodeForInsert(node) {
835 if (!Runtime.experiments.isEnabled('networkGroupingRequests')) 835 if (!Runtime.experiments.isEnabled('networkGroupingRequests'))
836 return /** @type {!Network.NetworkNode} */ (this._dataGrid.rootNode()); 836 return /** @type {!Network.NetworkNode} */ (this._dataGrid.rootNode());
837 837
838 var request = node.request(); 838 var request = node.request();
839 // TODO(allada) Make this dynamic and allow multiple grouping types. 839 // TODO(allada) Make this dynamic and allow multiple grouping types.
840 var groupKey = request.domain; 840 var groupKey = request.connectionId;
dgozman 2017/01/09 23:59:51 Unrelated?
841 var group = this._nodeGroups.get(groupKey); 841 var group = this._nodeGroups.get(groupKey);
842 if (group) 842 if (group)
843 return group; 843 return group;
844 group = new Network.NetworkGroupNode(this, groupKey); 844 group = new Network.NetworkGroupNode(this, groupKey);
845 this._nodeGroups.set(groupKey, group); 845 this._nodeGroups.set(groupKey, group);
846 this._dataGrid.rootNode().appendChild(group); 846 this._dataGrid.rootNode().appendChild(group);
847 return group; 847 return group;
848 } 848 }
849 849
850 reset() { 850 reset() {
(...skipping 867 matching lines...) Expand 10 before | Expand all | Expand 10 after
1718 Running: 'running', 1718 Running: 'running',
1719 FromCache: 'from-cache' 1719 FromCache: 'from-cache'
1720 }; 1720 };
1721 1721
1722 /** @type {!Array<string>} */ 1722 /** @type {!Array<string>} */
1723 Network.NetworkLogView._searchKeys = 1723 Network.NetworkLogView._searchKeys =
1724 Object.keys(Network.NetworkLogView.FilterType).map(key => Network.NetworkLog View.FilterType[key]); 1724 Object.keys(Network.NetworkLogView.FilterType).map(key => Network.NetworkLog View.FilterType[key]);
1725 1725
1726 /** @typedef {function(!SDK.NetworkRequest): boolean} */ 1726 /** @typedef {function(!SDK.NetworkRequest): boolean} */
1727 Network.NetworkLogView.Filter; 1727 Network.NetworkLogView.Filter;
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698