Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: content/renderer/media/media_stream_video_track.cc

Issue 2609863004: Pass camera facing to WebKit (Closed)
Patch Set: modify settings names Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_video_track.cc
diff --git a/content/renderer/media/media_stream_video_track.cc b/content/renderer/media/media_stream_video_track.cc
index dede54fecb104f1e46e97f43eb0ba1d2ed1dea20..552cf2c4ac060119ba716017d36e2ed497ce6f09 100644
--- a/content/renderer/media/media_stream_video_track.cc
+++ b/content/renderer/media/media_stream_video_track.cc
@@ -307,6 +307,20 @@ void MediaStreamVideoTrack::getSettings(
settings.frameRate = format->frame_rate;
settings.width = format->frame_size.width();
settings.height = format->frame_size.height();
+ media::CameraFacing facing = source_->GetCameraFacing();
mcasas 2017/01/05 20:26:37 nit: const
shenghao 2017/01/06 09:43:01 Done.
+ switch (facing) {
+ case media::CameraFacing::FRONT:
+ settings.facingMode =
+ blink::WebMediaStreamTrack::Settings::VideoFacingMode::User;
+ break;
+ case media::CameraFacing::BACK:
+ settings.facingMode = blink::WebMediaStreamTrack::Settings::
+ VideoFacingMode::Environment;
+ break;
+ default:
miu 2017/01/05 21:55:33 Don't include default clauses: Let the compiler fo
shenghao 2017/01/06 09:43:01 Done.
+ DVLOG(1) << "Unrecongnized CameraFacing value" << facing;
mcasas 2017/01/05 20:26:37 s/Unrecongnized/Unrecognized/ s/DVLOG(1)/DLOG(ERR
shenghao 2017/01/06 09:43:01 Deleted
+ break;
+ }
}
}
// TODO(hta): Extract the real value.

Powered by Google App Engine
This is Rietveld 408576698