Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: media/capture/video/linux/camera_facing_chromeos.cc

Issue 2609863004: Pass camera facing to WebKit (Closed)
Patch Set: change comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/linux/camera_facing_chromeos.cc
diff --git a/media/capture/video/linux/camera_facing_chromeos.cc b/media/capture/video/linux/camera_facing_chromeos.cc
index ad633d8dc524a31a3106d59f1c318d83dd3ad824..ad54ed4185e757836431ca31c057b91fb4c3df1b 100644
--- a/media/capture/video/linux/camera_facing_chromeos.cc
+++ b/media/capture/video/linux/camera_facing_chromeos.cc
@@ -16,6 +16,10 @@ namespace media {
namespace {
+// The value for each field in the enum matches the value in
+// /etc/camera/camera_characteristics.conf.
+enum LensFacing { FRONT = 0, BACK = 1 };
+
bool GetCameraId(const base::StringPiece& sub_key, int* camera_id) {
const base::StringPiece camera_id_prefix = "camera";
if (!sub_key.starts_with(camera_id_prefix))
@@ -43,7 +47,7 @@ CameraFacingChromeOS::CameraFacingChromeOS(
CameraFacingChromeOS::~CameraFacingChromeOS() {}
-CameraFacingChromeOS::LensFacing CameraFacingChromeOS::GetCameraFacing(
+VideoFacingMode CameraFacingChromeOS::GetCameraFacing(
const std::string& device_id,
const std::string& model_id) const {
std::string usb_id = GetUsbId(device_id);
@@ -156,10 +160,12 @@ void CameraFacingChromeOS::InitializeDeviceInfo(
}
switch (lens_facing) {
case LensFacing::FRONT:
- camera_id_to_facing_[camera_id] = LensFacing::FRONT;
+ camera_id_to_facing_[camera_id] =
+ VideoFacingMode::MEDIA_VIDEO_FACING_USER;
break;
case LensFacing::BACK:
- camera_id_to_facing_[camera_id] = LensFacing::BACK;
+ camera_id_to_facing_[camera_id] =
+ VideoFacingMode::MEDIA_VIDEO_FACING_ENVIRONMENT;
break;
default:
DLOG(ERROR) << "Invalid value for lens_facing: " << lens_facing;
« no previous file with comments | « media/capture/video/linux/camera_facing_chromeos.h ('k') | media/capture/video/linux/camera_facing_chromeos_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698