media/capture/video_capturer_source.cc - Issue 2609863004: Pass camera facing to WebKit

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/capture/video_capturer_source.cc

Issue 2609863004: Pass camera facing to WebKit (Closed)

Patch Set: address review comment Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« media/capture/video_capture_types.h ('K') | « media/capture/video_capturer_source.h ('k') | third_party/WebKit/public/platform/WebMediaStreamTrack.h » ('j') | third_party/WebKit/public/platform/WebMediaStreamTrack.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "media/capture/video_capturer_source.h"	5 #include "media/capture/video_capturer_source.h"

6	6

7 namespace media {	7 namespace media {

8	8

9 // TODO(mcasas): VideoCapturerSource is implemented in other .dll(s) (e.g.	9 // TODO(mcasas): VideoCapturerSource is implemented in other .dll(s) (e.g.

10 // content) in Windows component build. The current compiler fails to generate	10 // content) in Windows component build. The current compiler fails to generate

11 // object files for this destructor if it's defined in the header file and that	11 // object files for this destructor if it's defined in the header file and that

12 // breaks linking. Consider removing this file when the compiler+linker is able	12 // breaks linking. Consider removing this file when the compiler+linker is able

13 // to generate symbols across linking units.	13 // to generate symbols across linking units.

14 VideoCapturerSource::~VideoCapturerSource() {}	14 VideoCapturerSource::~VideoCapturerSource() {}

15	15

	16 VideoFacingMode VideoCapturerSource::GetVideoFacing() const {

	17 return VideoFacingMode::USER;
	mcasas 2017/01/11 22:24:59 Here I would return VideoFacingMode::NONE; Here I would return VideoFacingMode::NONE; shenghao 2017/01/12 08:10:48 Done. Show quoted text On 2017/01/11 22:24:59, mcasas wrote: > Here I would return VideoFacingMode::NONE; Done.
	18 }

	19

16 } // namespace media	20 } // namespace media

OLD	NEW