Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: third_party/WebKit/Source/core/style/FilterOperationsTest.cpp

Issue 2609803002: Use ShadowData in DropShadowFilterOperation (Closed)
Patch Set: Fix blend(...) order Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/FilterOperationsTest.cpp
diff --git a/third_party/WebKit/Source/core/style/FilterOperationsTest.cpp b/third_party/WebKit/Source/core/style/FilterOperationsTest.cpp
index 1c9596ba5caa359e0cc4b20d711d4db7b6878b92..5deb7473cd1bbda747a53427d6cc6f2aac18103b 100644
--- a/third_party/WebKit/Source/core/style/FilterOperationsTest.cpp
+++ b/third_party/WebKit/Source/core/style/FilterOperationsTest.cpp
@@ -46,8 +46,8 @@ TEST(FilterOperationsTest, mapRectBlur) {
TEST(FilterOperationsTest, mapRectDropShadow) {
FilterOperations ops;
- ops.operations().append(
- DropShadowFilterOperation::create(IntPoint(3, 8), 20, Color(1, 2, 3)));
+ ops.operations().append(DropShadowFilterOperation::create(
+ ShadowData(FloatPoint(3, 8), 20, 0, Normal, StyleColor(Color(1, 2, 3)))));
EXPECT_TRUE(ops.hasFilterThatMovesPixels());
EXPECT_EQ(IntRect(-54, -49, 124, 124),
enclosingIntRect(ops.mapRect(FloatRect(0, 0, 10, 10))));
@@ -67,8 +67,8 @@ TEST(FilterOperationsTest, mapRectDropShadowAndBoxReflect) {
// This is a case where the order of filter operations matters, and it's
// important that the bounds be filtered in the correct order.
FilterOperations ops;
- ops.operations().append(
- DropShadowFilterOperation::create(IntPoint(100, 200), 0, Color::black));
+ ops.operations().append(DropShadowFilterOperation::create(ShadowData(
+ FloatPoint(100, 200), 0, 0, Normal, StyleColor(Color::black))));
ops.operations().append(BoxReflectFilterOperation::create(
BoxReflection(BoxReflection::VerticalReflection, 50)));
EXPECT_TRUE(ops.hasFilterThatMovesPixels());
« no previous file with comments | « third_party/WebKit/Source/core/style/FilterOperation.cpp ('k') | third_party/WebKit/Source/core/style/ShadowData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698