Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp

Issue 2609803002: Use ShadowData in DropShadowFilterOperation (Closed)
Patch Set: Fix blend(...) order Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp
diff --git a/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp b/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp
index 1a164c4bd3c792039c5d8b4f74255f3afb257264..d9c56633523c49640f07043e7379f41143e276ad 100644
--- a/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp
+++ b/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp
@@ -258,13 +258,11 @@ FilterEffect* FilterEffectBuilder::buildFilterEffect(
break;
}
case FilterOperation::DROP_SHADOW: {
- DropShadowFilterOperation* dropShadowOperation =
- toDropShadowFilterOperation(filterOperation);
- float stdDeviation = dropShadowOperation->stdDeviation();
- float x = dropShadowOperation->x();
- float y = dropShadowOperation->y();
- effect = FEDropShadow::create(parentFilter, stdDeviation, stdDeviation,
- x, y, dropShadowOperation->getColor(), 1);
+ const ShadowData& shadow =
+ toDropShadowFilterOperation(*filterOperation).shadow();
+ effect = FEDropShadow::create(parentFilter, shadow.blur(),
+ shadow.blur(), shadow.x(), shadow.y(),
+ shadow.color().getColor(), 1);
break;
}
case FilterOperation::BOX_REFLECT: {
@@ -371,11 +369,10 @@ CompositorFilterOperations FilterEffectBuilder::buildFilterOperations(
break;
}
case FilterOperation::DROP_SHADOW: {
- const DropShadowFilterOperation& drop =
- toDropShadowFilterOperation(*op);
- filters.appendDropShadowFilter(WebPoint(drop.x(), drop.y()),
- drop.stdDeviation(),
- drop.getColor().rgb());
+ const ShadowData& shadow = toDropShadowFilterOperation(*op).shadow();
+ filters.appendDropShadowFilter(WebPoint(shadow.x(), shadow.y()),
+ shadow.blur(),
+ shadow.color().getColor());
break;
}
case FilterOperation::BOX_REFLECT: {

Powered by Google App Engine
This is Rietveld 408576698