third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2609803002: Use ShadowData in DropShadowFilterOperation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2609803002: Use ShadowData in DropShadowFilterOperation (Closed)

Patch Set: Fix blend(...) order Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSProperties.in ('k') | third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 55cf0444de026ab6d120d4a87c310dc304f9162a..0b1dbb416c183db51807ba35540f00f06079fa37 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -1817,15 +1817,13 @@ CSSValue* ComputedStyleCSSValueMapping::valueForFilter(

style));

break;

case FilterOperation::DROP_SHADOW: {

- DropShadowFilterOperation* dropShadowOperation =

- toDropShadowFilterOperation(filterOperation);

+ const auto& dropShadowOperation =

+ toDropShadowFilterOperation(*filterOperation);

filterValue = CSSFunctionValue::create(CSSValueDropShadow);

// We want our computed style to look like that of a text shadow (has

// neither spread nor inset style).

- ShadowData shadow(dropShadowOperation->location(),

- dropShadowOperation->stdDeviation(), 0, Normal,

- StyleColor(dropShadowOperation->getColor()));

- filterValue->append(*valueForShadowData(shadow, style, false));

+ filterValue->append(

+ *valueForShadowData(dropShadowOperation.shadow(), style, false));

break;

}

default: