Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: components/offline_pages/core/background/request_coordinator_unittest.cc

Issue 2609713002: [Offline pages] Completely remove offliner factory. (Closed)
Patch Set: add TODO Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/core/background/request_coordinator_unittest.cc b/components/offline_pages/core/background/request_coordinator_unittest.cc
index 1114bf69790c30efd8d7442c9bb8dfb22737583e..915e5ab2c2d6f57cc9329b9ce6c63f86084bfc15 100644
--- a/components/offline_pages/core/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/core/background/request_coordinator_unittest.cc
@@ -22,8 +22,6 @@
#include "components/offline_pages/core/background/device_conditions.h"
#include "components/offline_pages/core/background/network_quality_provider_stub.h"
#include "components/offline_pages/core/background/offliner.h"
-#include "components/offline_pages/core/background/offliner_factory.h"
-#include "components/offline_pages/core/background/offliner_factory_stub.h"
#include "components/offline_pages/core/background/offliner_policy.h"
#include "components/offline_pages/core/background/offliner_stub.h"
#include "components/offline_pages/core/background/request_queue.h"
@@ -300,7 +298,7 @@ RequestCoordinatorTest::~RequestCoordinatorTest() {}
void RequestCoordinatorTest::SetUp() {
std::unique_ptr<OfflinerPolicy> policy(new OfflinerPolicy());
- std::unique_ptr<OfflinerFactory> offliner_factory(new OfflinerFactoryStub());
+ std::unique_ptr<Offliner> offliner(new OfflinerStub());
// Save the offliner for use by the tests.
offliner_ = reinterpret_cast<OfflinerStub*>(
offliner_factory->GetOffliner(policy.get()));
@@ -310,7 +308,7 @@ void RequestCoordinatorTest::SetUp() {
std::unique_ptr<Scheduler> scheduler_stub(new SchedulerStub());
network_quality_estimator_.reset(new NetworkQualityProviderStub());
coordinator_.reset(new RequestCoordinator(
- std::move(policy), std::move(offliner_factory), std::move(queue),
+ std::move(policy), std::move(offliner), std::move(queue),
std::move(scheduler_stub), network_quality_estimator_.get()));
coordinator_->AddObserver(&observer_);
SetNetworkConnected(true);

Powered by Google App Engine
This is Rietveld 408576698