chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc - Issue 2609713002: [Offline pages] Completely remove offliner factory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2609713002: [Offline pages] Completely remove offliner factory. (Closed)

Patch Set: add TODO Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/background_loader_offliner_factory.cc ('k') | chrome/browser/android/offline_pages/prerendering_offliner_factory.h » ('j') | chrome/browser/android/offline_pages/request_coordinator_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

diff --git a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

index eb9b876e20d32d728090cecfc4485f2c6a461837..bf408a4a9e8024901334f08728e3f9a45aa8968e 100644

--- a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

+++ b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

@@ -14,14 +14,14 @@

#include "chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.h"

#include "chrome/browser/android/offline_pages/evaluation/evaluation_test_scheduler.h"

#include "chrome/browser/android/offline_pages/offline_page_model_factory.h"

-#include "chrome/browser/android/offline_pages/prerendering_offliner_factory.h"

+#include "chrome/browser/android/offline_pages/prerendering_offliner.h"

#include "chrome/browser/android/offline_pages/request_coordinator_factory.h"

#include "chrome/browser/net/nqe/ui_network_quality_estimator_service.h"

#include "chrome/browser/net/nqe/ui_network_quality_estimator_service_factory.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_android.h"

#include "chrome/common/chrome_constants.h"

-#include "components/offline_pages/core/background/offliner_factory.h"

+#include "components/offline_pages/core/background/offliner.h"

#include "components/offline_pages/core/background/offliner_policy.h"

#include "components/offline_pages/core/background/request_coordinator.h"

#include "components/offline_pages/core/background/request_notifier.h"

@@ -166,8 +166,9 @@ std::unique_ptr<KeyedService>

OfflinePageEvaluationBridge::GetTestingRequestCoordinator(

content::BrowserContext* context) {

std::unique_ptr<OfflinerPolicy> policy(new OfflinerPolicy());

- std::unique_ptr<OfflinerFactory> prerenderer_offliner(

- new PrerenderingOfflinerFactory(context));

+ std::unique_ptr<Offliner> prerenderer_offliner(new PrerenderingOffliner(

+ context, policy.get(),

+ OfflinePageModelFactory::GetForBrowserContext(context)));

scoped_refptr<base::SequencedTaskRunner> background_task_runner =

content::BrowserThread::GetBlockingPool()->GetSequencedTaskRunner(